Ignore large build folders in Docker builds#661
Merged
Conversation
djs55
approved these changes
Apr 13, 2026
Collaborator
|
Sorry could you fix the DCO issue (the signed-off-by line) (it’s a moby project thing) |
On my system `docker build` uploads about 2GB of data from Dune's `_build` and OPAM's `_opam` folder which takes a long time and isn't needed as the Docker image builds the code from scratch. This PR includes it so it only takes a few seconds to start building the container. Signed-off-by: Marek Kubica <marek@tarides.com>
Leonidas-from-XIV
force-pushed
the
faster-dockerbuild
branch
from
054f273 to
0408762
Compare
Contributor
Author
|
Yes sure, done! (we have the same DCO thing in the Dune repo) |
Contributor
Author
|
ping? |
Contributor
Author
|
Hi @djs55! Could you take a look at this PR? I think I addressed all the points. |
djs55
approved these changes
May 20, 2026
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On my system
docker builduploads about 2GB of data from Dune's_buildand OPAM's_opamfolder which takes a long time and isn't needed as the Docker image builds the code from scratch. These folders typically contain all dependencies and compilers so they can get pretty big.This PR excludes them so it only takes a few seconds to start building the container.
cc @djs55