Remove REPO_ROOT variable and depends.sh#657
Merged
Merged
Conversation
They seem not to be used anywhere so might as well remove them. Signed-off-by: Marek Kubica <marek@tarides.com>
Leonidas-from-XIV
force-pushed
the
repo-root-cleanup
branch
from
412b127 to
ac12c23
Compare
Contributor
Author
|
@djs55 Could you please take a look? This removes a dependency on a |
Contributor
Author
|
@djs55 Do you have a moment to review this? |
Contributor
Author
|
@djs55 Do you know if there's a specific use for this code? It didn't seem that way to me unless I missed something and removing it saves a |
djs55
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
REPO_ROOTvariable from the Makefile does not seem to be used anywhere. The only mention ofREPO_ROOTisscripts/depends.shwhich is also not referenced anywhere (and not called in theMakefileeither).This PR removes both of them.