archive: rewrite chtimesAt using windows.Openat - #88
Open
thaJeztah wants to merge 5 commits into
Open
Conversation
thaJeztah
commented
Jul 28, 2026
thaJeztah
commented
Member
- alternative to archive: fix creation time updates on Windows #79, but forking Go's internal/syscall/windows package
thaJeztah
force-pushed
the
fix_windows_alt
branch
2 times, most recently
from
July 28, 2026 11:16
29755be to
adbe9a0
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #88 +/- ##
===========================================
- Coverage 65.81% 49.17% -16.64%
===========================================
Files 42 53 +11
Lines 2039 3223 +1184
===========================================
+ Hits 1342 1585 +243
- Misses 519 1410 +891
- Partials 178 228 +50 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
thaJeztah
force-pushed
the
fix_windows_alt
branch
10 times, most recently
from
July 28, 2026 14:09
846d744 to
89bebbb
Compare
thaJeztah
force-pushed
the
fix_windows_alt
branch
from
July 30, 2026 12:03
89bebbb to
1e73f3f
Compare
This forks the Openat implementation from Go's `internal/syscall/windows` package at go1.26.5; https://github.com/golang/go/tree/go1.26.0/src/internal/syscall/windows Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Code is unmodified, with the exception of "internal/oserror", which is replaced with a `os.ErrInvalid` (which uses the same error under the hood) and a testenv.Executable helper. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
fix_windows_alt
branch
2 times, most recently
from
July 30, 2026 14:14
85ec686 to
41edda1
Compare
thaJeztah
changed the title
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
fix_windows_alt
branch
from
July 30, 2026 14:15
41edda1 to
7ba74cc
Compare
thaJeztah
changed the title
thaJeztah
marked this pull request as ready for review
July 30, 2026 16:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.