Retry transient registry auth token requests - #7109
Open
charle-z wants to merge 1 commit into
Open
Conversation
Signed-off-by: Carlos Acosta <93443910+charle-z@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6981.
Registry blob and manifest fetches already use BuildKit's resolver retry handler for transient transport failures, but registry token HTTP requests bypassed that path. A connection reset or 5xx from the token endpoint therefore failed authorization immediately.
This change reuses the same existing retry classification and backoff for token HTTP requests in both the resolver and session auth provider. The existing GET/POST fallback behavior for 401/404/405 is unchanged, and permanent errors such as 403 are not retried.
Validation:
go test ./session/auth/... ./util/resolver/... -count=1go test -race ./session/auth/... ./util/resolver/... -count=1go vet ./session/auth/... ./util/resolver/...git diff --checkThe full
make validate-allgate requires Docker/buildx, which is not available in the local validation environment.