Skip to content

vendor: github.com/docker/go-metrics v0.1.0 - #7077

Open
thaJeztah wants to merge 1 commit into
moby:masterfrom
thaJeztah:bump_go_metric
Open

vendor: github.com/docker/go-metrics v0.1.0#7077
thaJeztah wants to merge 1 commit into
moby:masterfrom
thaJeztah:bump_go_metric

Conversation

@thaJeztah

@thaJeztah thaJeztah commented Aug 26, 2026

Copy link
Copy Markdown
Member

vendor: github.com/docker/go-metrics v0.1.0

  • Add support for creating timers with custom histogram buckets.
  • Update github.com/prometheus/client_golang to v1.20.5.
  • Update the minimum supported Go version to Go 1.21.
  • Improve HTTP handler instrumentation, including minor performance improvements and cleanup.
  • Avoid mutating shared label maps when creating namespaces and metrics.
  • Encapsulate the Prometheus collector used by HTTPMetric.
  • Improve package and API documentation.
  • Update golang.org/x/sys and other dependencies.

full diff: docker/go-metrics@v0.0.1...v0.1.0

@github-actions github-actions Bot added the area/dependencies Pull requests that update a dependency file label Aug 26, 2026
@thaJeztah
thaJeztah force-pushed the bump_go_metric branch 2 times, most recently from be75167 to 6839763 Compare August 26, 2026 12:38
@thaJeztah
thaJeztah marked this pull request as ready for review August 26, 2026 12:38
crazy-max
crazy-max previously approved these changes Aug 26, 2026
@crazy-max
crazy-max dismissed their stale review August 26, 2026 14:09

upstream first?

Comment thread go.mod
github.com/dimchansky/utfbom v1.1.1 // indirect
github.com/docker/docker-credential-helpers v0.9.8 // indirect
github.com/docker/go-metrics v0.0.1 // indirect
github.com/docker/go-metrics v0.1.0 // indirect

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems this transitive dep is introduced by https://github.com/containerd/stargz-snapshotter/blob/c2bf18e5a94dcfd959cabf744f4bbb4ef8d980a2/go.mod#L16. Maybe it should be vendored there first to make sure there is no regression?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's also used by containerd and moby; already have PRs opened there to verify, so updating here to align with moby as we do for other dependencies.

- Add support for creating timers with custom histogram buckets.
- Update `github.com/prometheus/client_golang` to v1.20.5.
- Update the minimum supported Go version to Go 1.21.
- Improve HTTP handler instrumentation, including minor performance improvements and cleanup.
- Avoid mutating shared label maps when creating namespaces and metrics.
- Encapsulate the Prometheus collector used by `HTTPMetric`.
- Improve package and API documentation.
- Update `golang.org/x/sys` and other dependencies.

full diff: docker/go-metrics@v0.0.1...v0.1.0

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah

Copy link
Copy Markdown
Member Author

(rebased)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants