Skip to content

chore: upgrade mobilecli to 1.0.13 - #334

Merged
gmegidish merged 1 commit into
mainfrom
chore/upgrade-mobilecli
Sep 21, 2026
Merged

gmegidish merged 1 commit into
mainfrom
chore/upgrade-mobilecli

Conversation

@gmegidish

Copy link
Copy Markdown
Member

Summary

Bumps mobilecli 1.0.12 → 1.0.13 in @mobilewright/driver-mobilecli.

1.0.13 includes mobile-next/mobilecli#440, which keeps more iOS element types in the UI dump. That is what lets these getByRole() roles match on iOS at all: slider, list, listitem, tab, link, header, plus progressbar, alert and combobox from #332. It also includes mobile-next/mobilecli#439 (fresh accessibility tree on every Android dump).

Docs

Rewrites the "iOS source filtering" note in docs/src/guides/locators.md. The gap is narrower, not gone:

  • always included: Button, text fields, Switch, WebView, and now Slider, Picker, PickerWheel
  • everything else only when it has a label, name or accessibilityIdentifier
  • XCUIElementTypeOther only with an accessibilityIdentifier

Test plan

  • npm run lint
  • npx playwright test for query-engine and driver-mobilecli — 199 passed, 2 skipped
  • package-lock.json diff touches only mobilecli and its platform packages
  • iOS smoke: getByRole('slider') against a real simulator

@coderabbitai

coderabbitai Bot commented Sep 21, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Essentials

Run ID: c6eafd94-761e-448a-9bd6-f14ab90bed86

📥 Commits

Reviewing files that changed from the base of the PR and between 33ea23a and c94396f.

⛔ Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (2)
  • docs/src/guides/locators.md
  • packages/driver-mobilecli/package.json

Included review availability: Your plan provides up to 5 included reviews per hour; 1 remains after this review.


Walkthrough

The mobilecli dependency was updated from 1.0.12 to 1.0.13. The iOS locator documentation now describes the filtering rules for listed controls, labeled or identified mapped classes, XCUIElementTypeOther, and versions before 1.0.13.

Priority: ⬇️ Low

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely identifies the main change: upgrading the mobilecli dependency to version 1.0.13.
Description check ✅ Passed The description accurately explains the dependency upgrade, its iOS and Android effects, documentation updates, test results, and the pending iOS smoke test.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

@gmegidish
gmegidish merged commit def8dea into main Sep 21, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant