Skip to content

feat: re-export Role type from mobilewright and @mobilewright/test - #333

Merged
gmegidish merged 1 commit into
mainfrom
feat/reexport-role-type
Sep 21, 2026
Merged

gmegidish merged 1 commit into
mainfrom
feat/reexport-role-type

Conversation

@gmegidish

Copy link
Copy Markdown
Member

Summary

Follow-up to #160 / #186. Role (the union accepted by native getByRole()) was only exported from @mobilewright/core. Users import from mobilewright or @mobilewright/test, so typing a helper or page object meant reaching into an internal package.

import { test, type Role } from '@mobilewright/test';

function tapByRole(screen: Screen, role: Role, name: string) {  }

Type-only re-export, no runtime change.

Credit

The Role type and its derivation from ROLE_TYPE_MAP are by @Dhakshath11 in #186. Original request by @vethman in #160.

Test plan

  • npm run lint (tsc --noEmit && eslint .)

@coderabbitai

coderabbitai Bot commented Sep 21, 2026

Copy link
Copy Markdown

Warning

Review limit reached

  • Run on-demand review

This review includes 2 billable files and costs up to $0.50.

  • Ask an admin to make reviews automatic

Open in CodeRabbit

Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing.

Or wait 22 minutes for your next included review.

Check out review usage here.

View limit details

Limit details: You’ve used all 2 included reviews currently available. Your 50 included PR review attempts over the past 7 days set your current allowance at 2 reviews per hour.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Essentials

Run ID: e3b0afaf-acc6-4196-9340-18899d613666

📥 Commits

Reviewing files that changed from the base of the PR and between 39679dc and fe36e23.

📒 Files selected for processing (2)
  • packages/mobilewright/src/index.ts
  • packages/test/src/index.ts

Comment @coderabbitai help to get the list of available commands.

@gmegidish
gmegidish merged commit 42b5391 into main Sep 21, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant