Skip to content

fix: never auto-open the HTML report, document npm init mobilewright@latest - #17

Merged
gmegidish merged 1 commit into
mainfrom
fix/html-report-open-never
Sep 17, 2026
Merged

gmegidish merged 1 commit into
mainfrom
fix/html-report-open-never

Conversation

@gmegidish

Copy link
Copy Markdown
Member

Summary

  • HTML report no longer blocks the terminal. The example test fails for almost every new user (their app has no "Welcome" text), and with reporter: 'html' a failing run in a terminal serves the report, opens the browser and waits for Ctrl-C. The generated config now uses reporter: [['html', { open: 'never' }]]. Compatible with fix: rebrand the HTML report as Mobilewright end to end mobilewright#324, which routes config html reporters through the branded reporter and keeps open.
  • .gitignore also gets /mobilewright-report/ (the report folder after mobilewright#324), alongside /playwright-report/ for older mobilewright releases.
  • README says npm init mobilewright@latest, so users don't run an older scaffolder cached by npx. Yarn and pnpm lines unchanged, same as Playwright's README.

Test plan

  • npm test (53): new test for the reporter line; gitignore tests updated
  • npm run lint, npm run build
  • Generated config with mobilewright 0.0.59: mobilewright test --list and tsc --noEmit pass
  • Failing test run on a device returns to the prompt without opening the report

…latest

- generated config uses reporter: [['html', { open: 'never' }]] so a failing
  first run doesn't serve the report and block the terminal
- .gitignore also covers /mobilewright-report/
- README: npm init mobilewright@latest
@coderabbitai

coderabbitai Bot commented Sep 17, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Essentials

Run ID: 6fd9e3b4-e3f1-4352-bb77-76e50cc96a9c

📥 Commits

Reviewing files that changed from the base of the PR and between c6070d3 and 8fa3cf8.

📒 Files selected for processing (3)
  • README.md
  • src/project.ts
  • test/project.test.ts

Included review availability: 2 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 3 reviews per hour.


Walkthrough

The README now uses npm init mobilewright@latest. Generated configurations set the HTML reporter to open: 'never'. Generated and patched .gitignore files now ignore /mobilewright-report/. Tests cover the reporter setting and the updated .gitignore behavior.

Priority: ➖ Normal

Severity of issue fixed: Medium

Merge Risk: ⚪ Minimal · up to 8fa3c

The scaffolding changes are ready to merge with no identified user-facing or operational risk.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 2 files. (1 skipped: 1 … Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the two main changes: preventing automatic HTML report opening and documenting npm init mobilewright@latest.
Description check ✅ Passed The description directly explains the reporter configuration, .gitignore update, README update, and test coverage. It is related to the changeset and provides sufficient context.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 2 files. (1 skipped: 1 unsupported.)

  • Fix all pre-merge checks with AI
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

@gmegidish
gmegidish merged commit 728aa69 into main Sep 17, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant