[BUG] fix axis label overlap in plot_volume_source_estimates by using draw_idle()#13708
Open
Famous077 wants to merge 2 commits intomne-tools:mainfrom
Open
[BUG] fix axis label overlap in plot_volume_source_estimates by using draw_idle()#13708Famous077 wants to merge 2 commits intomne-tools:mainfrom
Famous077 wants to merge 2 commits intomne-tools:mainfrom
Conversation
for more information, see https://pre-commit.ci
Author
|
All tests in mne/viz/tests/test_3d_mpl.py pass locally. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed issue #13700
Problem
When plotting volume source estimates, axis labels were mangled and
overlapping on the colorbar and y-axis of the time series plot.
The MRI and colorbar also appeared shifted relative to the black background.
Root Cause
canvas.draw()was being called after each click/keypress event in_press()and_onclick(), causing blitting artifacts when combinedwith nilearn's plotting functions.
Fix
Replaced
canvas.draw()withcanvas.draw_idle()in both_press()and
_onclick()functions inmne/viz/_3d.py. This lets matplotlibschedule the redraw properly and avoids the rendering artifacts.
Changes
mne/viz/_3d.py:canvas.draw()→canvas.draw_idle()in_press()and_onclick()doc/changes/dev/13700.bugfix.rst: changelog entrydoc/changes/names.inc: added contributor name