ENH: Add pythonic keyword interface to set_config#13681
Open
Aniketsy wants to merge 6 commits intomne-tools:mainfrom
Open
ENH: Add pythonic keyword interface to set_config#13681Aniketsy wants to merge 6 commits intomne-tools:mainfrom
Aniketsy wants to merge 6 commits intomne-tools:mainfrom
Conversation
Contributor
|
Hi Aniketsy, Thank you for contributing. I haven't gone through your code in detail yet, but saw that a few of your tests are failing. I recommend running tests locally to make sure they pass and understand why they fail, before pushing your commits. Running tests locally is documented in the contributing guide, let us know if you run into issues. |
Contributor
Author
|
@CarinaFo thanks, I had only run one test file. I’ll run the full test suite and verify before pushing. |
Aniketsy
requested review from
agramfort,
drammock and
larsoner
as code owners
Contributor
Author
|
@CarinaFo Hi, all CI checks are green now. Please review when you get a chance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #13052
This is an initial implementation based on the discussion in the issue. please let me know if this needs further improvement.
I used AI while drafting tests to help improve edge case coverage, and run the test locally (tets_config.py)
Thanks!