Draft
Conversation
Contributor
Author
|
Okay I only see this now. There's already a typing utility in the repo. Would it be better if we add more elaborated types there? and import the type hints from there or Just say so and I'll start working it 😉. |
Member
|
There was at one point a lot of discussion of types and I don't offhand remember the outcomes. See for example #8218 (comment) |
Contributor
Author
|
hey @scott-huberty for simplicity(only for right now), I've done this: I see that you gave the notion about creatin a new typing module here - but there already exists one but there's nothing defined in there :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference issue - Fixes #13597.
Fixes the type error:
which previously would've looked like:
