Skip to content

feat(spf): opt-in MoQ audio renderer over the shared worklet audio core - #67

Merged
mmcc merged 7 commits into
mmcc/moqfrom
feat/moq-worklet-audio-renderer
Oct 19, 2026
Merged

mmcc merged 7 commits into
mmcc/moqfrom
feat/moq-worklet-audio-renderer

Conversation

@mmcc

@mmcc mmcc commented Oct 19, 2026 •

Copy link
Copy Markdown
Owner

Refs #66. This is the unblocked part of the plan in #66 (comment). It does not close #66.

What

createWorkletAudioRendererActor puts the MoQ audio renderer on top of the shared AudioWorklet audio core, @mux/moq-media's createAudioPlayer from muxinc/relay-sdks#323. It sits behind the existing AudioRendererActor seam, so the video renderer, trackPlayoutTime, syncLatency and adaptLatencyTarget are unchanged.

The engine takes the core as createAudioPlayer in its config. When it is absent, the AudioBufferSourceNode renderer stays the default.

  • Seam. The renderer types against a structural interface that mirrors the parts of AudioPlayer, AudioPlayerInput and PlayoutClock it uses. @mux/moq-media is not a dependency (see below).
  • Metering. Frames move from the subscriber's jitter buffer into input.push so the worklet holds about its own jitterTargetUs. v10's target latency stays in the subscriber buffer. The core's adaptive target is left alone, and the target latency v10 resolves caps its ceiling through clock.targetLatencyUs.
  • Join-at-edge anchor. Frames behind getJoinAnchorUs() are dropped before the first push. A timeline jump over 1 s calls input.cut() and re-arms the anchor. When a re-join's whole buffer is already past the anchor, the clock is placed at the anchor and the head is held back until it is due.
  • Clock. The renderer owns the clock the core reports into, so getClockTimeUs() keeps its contract: undefined before audio, held where the worklet ran dry (not wall-paced), and resuming seamlessly when audio does. Reports of audio that was not pushed on the current timeline are ignored.
  • Underruns. Counted on the renderer's own dry edges, as audio-renderer counts them, across track changes. The core's stats.underruns skips stalls longer than its jitter ceiling, which adaptLatencyTarget still needs as failure evidence.
  • Adapter. The render context now forwards baseLatency and outputLatency, and exposes baseContext, the real context an AudioWorkletNode needs.

Why opt-in

  1. No rate control in the core. v10 builds and sheds depth with ±5 % playoutRate nudges. The core can only trim or run dry, so this path ignores nudges. I filed muxinc/relay-sdks#329 for AudioPlayerInput.playbackRate.
  2. No public package yet. muxinc/relay-sdks is private and this repo is public, so vendoring the core would publish unreleased code. The npm release is tracked in muxinc/relay-sdks#222 and Docs: Site Setup videojs/v10#224.

Verification

  • pnpm -F @videojs/spf test: 2410 passed, 11 skipped. That includes 9 new createWorkletAudioRendererActor tests against a fake core and a setupAudioRenderer selection test.
  • tsgo -p packages/spf/tsconfig.json: clean.
  • vp lint / vp fmt on the changed files: no new warnings.
  • Headless Chromium, one browser at a time. I used the sandbox's loopback relay with the real core copied from relay-sdks 140b8a0 into the gitignored apps/sandbox/src/; none of it is committed. Results over 12 s:
Worklet core Source nodes
Clock owner, rate audio, 1.00× audio, 1.00×
Underruns 0 0
Output RMS ≈ 0.01, ~50 reports/s, jitter target 60 → 50 ms —
Measured latency 0.145 s for the whole run, nudging at 0.95 0.12 → 0.48 s, stable after 7.5 s

The latency row is gap 1 measured live. A fresh join plays at the edge, and only a rate nudge can build depth back to the 500 ms target. Until videojs#329 lands, the worklet path stays nudging, which also freezes adaptLatencyTarget.

Follow-up (#66)

When @mux/moq-media is published with playbackRate: add the dependency, apply getPlaybackRate() to input.playbackRate, make the core the default, and delete the AudioBufferSourceNode path.

🤖 Generated with Claude Code


Summary by cubic

Adds an opt-in MoQ audio renderer over the shared AudioWorklet audio core, @mux/moq-media's createAudioPlayer, behind the existing AudioRendererActor seam. When no createAudioPlayer is configured in the engine config, the AudioBufferSourceNode renderer stays the default.

Frames move from the subscriber's jitter buffer into the worklet so the core holds about its own jitter target, while v10's target latency stays in the subscriber buffer and caps the core's ceiling via the clock. The video renderer, trackPlayoutTime, syncLatency, and adaptLatencyTarget are unchanged. The clock keeps its contract — undefined before audio, held where the worklet ran dry — and never steps back in recovery: the hold releases only when the core reports itself stopped or a report passes the dry point, and a floor keeps the clock at the held position until the refill's first report reaches it. A placed re-join clock stops at the end of the audio pushed and holds there until the core plays, and a frozen placement refills like an underrun so a gap past its fill horizon cannot strand it. Reports are timed on AudioContext.currentTime, so the clock freezes through pause and resumes without jumping, and reports from removed inputs are ignored. Underruns count every time the worklet runs dry, as audio-renderer counts them, including a dry edge that lands on a track change before the next tick. Frame durations are read from each Opus packet's TOC byte, falling back to the shortest step between frames, so gaps of lost packets don't extend pushed audio past where it ends.

Why opt-in

  • The core has no playback rate yet (muxinc/relay-sdks#329), so playoutRate nudges are ignored on this path.
  • @mux/moq-media is unreleased and this repo is public, so the core is injected as a structural interface rather than a dependency.

Written for commit c2beabf. Summary will update on new commits.

View guided diff Turn on auto-fix

Adds createWorkletAudioRendererActor behind the AudioRendererActor seam,
driving @mux/moq-media's createAudioPlayer through a structural interface
injected as createAudioPlayer (engine config). Keeps the join-at-edge
anchor (including re-join placement), a clock that holds where the worklet
ran dry, and underrun counting from input stats; meters frames so the
worklet holds its own jitter target and v10's latency stays in the
subscriber buffer.

Opt-in: the core has no playback rate yet (muxinc/relay-sdks#329), so
playoutRate nudges do not reach audio on this path.

Refs #66
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-19T18:10:34.945052Z 31f3391 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 31f33919fd

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

/** See `audio-renderer`'s threshold of the same name: a jump this large, either way, is a new timeline. */
const DISCONTINUITY_THRESHOLD_US = TIMELINE_DISCONTINUITY_US;

const performanceNowUs = (): number => performance.now() * 1000;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Freeze the worklet clock while the audio context is suspended

When MoqMediaMixin.pause() suspends the AudioContext, this default performance.now() clock continues advancing. Consequently, getClockTimeUs() advances toward pushedEndUs, the tick can falsely classify the suspended worklet as dry and enqueue a refill, and the first report after resume can re-anchor the exposed media clock backward. This affects every pause/resume on the opt-in worklet path and can add latency or stall/slip the audio-slaved video; use a time source that freezes with the audio context, or explicitly freeze the renderer clock across suspension.

AGENTS.md reference: packages/spf/src/AGENTS.md:L21-L21

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in a38555e. The renderer's clock and fill-stall timer now run on AudioContext.currentTime, which stops when the adapter suspends the context. performance.now() remains only as the core's localNow, used to convert each report's render time into context time. Covered by 'freezes the clock and stops metering while the context is suspended'. Also checked live in headless Chromium: during a 2 s pause the clock held at 3.985 s, nothing was pushed, there were no underruns, and playback resumed from the same point.

@github-actions

github-actions Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

📦 Bundle Size Report

🎨 @videojs/html

Path Base initial PR initial Initial diff Lazy diff
/media/simple-moq-video 28.96 kB 30.06 kB +1.10 kB (+3.8%) —
Presets (7)
Entry Initial Lazy
/video (default) 64.34 kB 56.03 kB
/video (default + hls) 66.08 kB 56.03 kB
/video (minimal) 64.88 kB 56.03 kB
/video (minimal + hls) 66.49 kB 56.03 kB
/audio (default) 48.22 kB 56.03 kB
/audio (minimal) 48.51 kB 56.03 kB
/background 11.86 kB 56.03 kB
Media (19)
Entry Initial
/media/mux-video 3.03 kB
/media/mux-audio 2.68 kB
/media/background-video 1.16 kB
/media/cloudflare-video 2.90 kB
/media/dash-video 2.63 kB
/media/hls-audio 23.61 kB
/media/hls-background-video 17.49 kB
/media/hls-video 33.89 kB
/media/hlsjs-video 2.63 kB
/media/mux-background-video 17.47 kB
/media/native-hls-video 7.68 kB
/media/shaka-video 2.63 kB
/media/simple-moq-video 30.06 kB
/media/spotify-audio 3.02 kB
/media/tiktok-video 3.12 kB
/media/twitch-video 2.93 kB
/media/vimeo-video 2.90 kB
/media/wistia-video 607 B
/media/youtube-video 2.90 kB
Players (5)
Entry Initial Lazy
/video/player 9.97 kB 56.03 kB
/audio/player 6.14 kB 56.03 kB
/background/player 4.46 kB 56.03 kB
/live-video/player 9.33 kB 56.03 kB
/live-audio/player 6.16 kB 56.03 kB
Skins (29)
Entry Type Initial Lazy
/video/minimal-skin.css css 8.29 kB —
/video/skin.css css 8.00 kB —
/video/minimal-skin js 63.24 kB 56.03 kB
/video/minimal-skin2 js 8.27 kB —
/video/skin js 62.80 kB 56.03 kB
/video/skin2 js 7.99 kB —
/audio/minimal-skin.css css 6.07 kB —
/audio/skin.css css 5.80 kB —
/audio/minimal-skin js 47.00 kB 56.03 kB
/audio/minimal-skin2 js 6.05 kB —
/audio/skin js 46.74 kB 56.03 kB
/audio/skin2 js 5.78 kB —
/background/skin.css css 141 B —
/background/skin js 10.11 kB 56.03 kB
/background/skin2 js 159 B —
/live-video/minimal-skin.css css 6.77 kB —
/live-video/skin.css css 6.69 kB —
/live-video/minimal-skin js 50.81 kB 56.03 kB
/live-video/minimal-skin2 js 6.77 kB —
/live-video/skin js 50.73 kB 56.03 kB
/live-video/skin2 js 6.67 kB —
/live-audio/minimal-skin.css css 4.77 kB —
/live-audio/skin.css css 4.67 kB —
/live-audio/minimal-skin js 36.17 kB 56.03 kB
/live-audio/minimal-skin2 js 4.77 kB —
/live-audio/skin js 36.14 kB 56.03 kB
/live-audio/skin2 js 4.66 kB —
/global.css css 239 B —
/shadow.css css 78 B —
UI Components (62)
Entry Initial Lazy
/ui/airplay-button 11.52 kB 56.03 kB
/ui/alert-dialog 8.98 kB 56.03 kB
/ui/audio-track-radio-group 11.62 kB 56.03 kB
/ui/buffering-indicator 8.84 kB 56.03 kB
/ui/captions-button 11.76 kB 56.03 kB
/ui/captions-radio-group 11.66 kB 56.03 kB
/ui/cast-button 11.51 kB 56.03 kB
/ui/container 9.71 kB 56.03 kB
/ui/controls 9.03 kB 56.03 kB
/ui/controls-backdrop 1.69 kB 56.03 kB
/ui/controls-content 1.67 kB 56.03 kB
/ui/dialog 8.92 kB 56.03 kB
/ui/dialog-backdrop 1.70 kB 56.03 kB
/ui/dialog-close 2.06 kB 56.03 kB
/ui/dialog-description 1.69 kB 56.03 kB
/ui/dialog-popup 1.90 kB 56.03 kB
/ui/dialog-title 1.70 kB 56.03 kB
/ui/error-dialog 12.62 kB 56.03 kB
/ui/fullscreen-button 11.50 kB 56.03 kB
/ui/gesture 9.96 kB 56.03 kB
/ui/hotkey 10.37 kB 56.03 kB
/ui/live-button 10.02 kB 56.03 kB
/ui/menu 19.18 kB 56.03 kB
/ui/menu-checkbox-item 1.97 kB 56.03 kB
/ui/menu-content 7.64 kB 56.03 kB
/ui/menu-group 2.09 kB 56.03 kB
/ui/menu-group-label 1.64 kB —
/ui/menu-item 2.29 kB 56.03 kB
/ui/menu-item-indicator 1.38 kB 56.03 kB
/ui/menu-radio-group 3.02 kB 56.03 kB
/ui/menu-radio-item 2.14 kB 56.03 kB
/ui/menu-separator 1.30 kB 56.03 kB
/ui/mute-button 11.52 kB 56.03 kB
/ui/pip-button 11.48 kB 56.03 kB
/ui/play-button 11.46 kB 56.03 kB
/ui/playback-rate-button 11.56 kB 56.03 kB
/ui/playback-rate-radio-group 11.62 kB 56.03 kB
/ui/popover 8.76 kB 56.03 kB
/ui/poster 9.15 kB 56.03 kB
/ui/quality-radio-group 12.12 kB 56.03 kB
/ui/seek-button 11.50 kB 56.03 kB
/ui/seek-indicator 12.95 kB 56.03 kB
/ui/seek-indicator-value 1.10 kB —
/ui/slider 11.88 kB 56.03 kB
/ui/slider-preview 2.01 kB 56.03 kB
/ui/status-announcer 10.86 kB 56.03 kB
/ui/status-indicator 13.29 kB 56.03 kB
/ui/status-indicator-value 1.10 kB —
/ui/thumbnail 10.58 kB 56.03 kB
/ui/time 11.29 kB 56.03 kB
/ui/time-slider 13.38 kB 56.03 kB
/ui/time-slider-chapter-title 9.04 kB 56.03 kB
/ui/time-slider-chapters 9.88 kB 56.03 kB
/ui/title 8.44 kB 56.03 kB
/ui/tooltip 10.13 kB 56.03 kB
/ui/tooltip-label 1.21 kB —
/ui/tooltip-shortcut 1.18 kB —
/ui/volume-indicator 13.26 kB 56.03 kB
/ui/volume-indicator-fill 1.11 kB —
/ui/volume-indicator-value 1.10 kB —
/ui/volume-popover 15.14 kB 56.03 kB
/ui/volume-slider 12.58 kB 56.03 kB
⚛️ @videojs/react — no changes
Presets (7)
Entry Initial Lazy
/video (default) 58.84 kB 56.03 kB
/video (default + hls) 59.33 kB 56.03 kB
/video (minimal) 58.93 kB 56.03 kB
/video (minimal + hls) 59.39 kB 56.03 kB
/audio (default) 45.68 kB 56.03 kB
/audio (minimal) 45.68 kB 56.03 kB
/background 908 B 56.03 kB
Media (22)
Entry Initial
/media/mux-video/hls-js 1.46 kB
/media/mux-video/spf 1.46 kB
/media/mux-audio/hls-js 1.12 kB
/media/mux-audio/spf 1.13 kB
/media/background-video 513 B
/media/cloudflare-video 1.81 kB
/media/dash-video 1.11 kB
/media/hls-audio 22.36 kB
/media/hls-background-video 17.49 kB
/media/hls-video 32.59 kB
/media/hlsjs-video 1.12 kB
/media/mux-audio 1.12 kB
/media/mux-background-video 17.49 kB
/media/mux-video 1.45 kB
/media/native-hls-video 6.32 kB
/media/shaka-video 1.11 kB
/media/spotify-audio 1.89 kB
/media/tiktok-video 1.81 kB
/media/twitch-video 1.84 kB
/media/vimeo-video 1.79 kB
/media/wistia-video 1.41 kB
/media/youtube-video 1.79 kB
Extensions (2)
Entry Initial
/extensions/google-cast 1.77 kB
/extensions/mux-data 1.80 kB
Players (5)
Entry Initial Lazy
/video/player 8.22 kB 56.03 kB
/audio/player 4.38 kB 56.03 kB
/background/player 2.64 kB 56.03 kB
/live-video/player 7.60 kB 56.03 kB
/live-audio/player 4.40 kB 56.03 kB
Skins (18)
Entry Type Initial Lazy
/video/minimal-skin.css css 8.12 kB —
/video/skin.css css 7.81 kB —
/video/minimal-skin js 58.75 kB 56.03 kB
/video/skin js 58.64 kB 56.03 kB
/audio/minimal-skin.css css 5.88 kB —
/audio/skin.css css 5.60 kB —
/audio/minimal-skin js 45.56 kB 56.03 kB
/audio/skin js 45.60 kB 56.03 kB
/background/skin.css css 97 B —
/background/skin js 518 B —
/live-video/minimal-skin.css css 6.60 kB —
/live-video/skin.css css 6.51 kB —
/live-video/minimal-skin js 48.61 kB 56.03 kB
/live-video/skin js 48.64 kB 56.03 kB
/live-audio/minimal-skin.css css 4.58 kB —
/live-audio/skin.css css 4.47 kB —
/live-audio/minimal-skin js 33.79 kB 56.03 kB
/live-audio/skin js 33.79 kB 56.03 kB
UI Components (39)
Entry Initial Lazy
/ui/airplay-button 11.22 kB 56.03 kB
/ui/alert-dialog 5.20 kB 56.03 kB
/ui/audio-track 8.35 kB 56.03 kB
/ui/audio-track-radio-group 10.78 kB 56.03 kB
/ui/buffering-indicator 8.40 kB 56.03 kB
/ui/captions-button 11.19 kB 56.03 kB
/ui/captions-radio-group 10.88 kB 56.03 kB
/ui/cast-button 11.22 kB 56.03 kB
/ui/controls 8.29 kB 56.03 kB
/ui/dialog 5.19 kB 56.03 kB
/ui/error-dialog 12.61 kB 56.03 kB
/ui/fullscreen-button 11.17 kB 56.03 kB
/ui/gesture 8.60 kB 56.03 kB
/ui/hotkey 8.99 kB 56.03 kB
/ui/live-button 9.53 kB 56.03 kB
/ui/menu 22.01 kB 56.03 kB
/ui/mute-button 11.22 kB 56.03 kB
/ui/pip-button 11.18 kB 56.03 kB
/ui/play-button 11.16 kB 56.03 kB
/ui/playback-rate 8.41 kB 56.03 kB
/ui/playback-rate-button 11.14 kB 56.03 kB
/ui/playback-rate-radio-group 10.85 kB 56.03 kB
/ui/popover 9.12 kB 56.03 kB
/ui/poster 8.61 kB 56.03 kB
/ui/quality 8.77 kB 56.03 kB
/ui/quality-radio-group 11.19 kB 56.03 kB
/ui/seek-button 11.18 kB 56.03 kB
/ui/seek-indicator 12.91 kB 56.03 kB
/ui/slider 14.34 kB 56.03 kB
/ui/status-announcer 10.81 kB 56.03 kB
/ui/status-indicator 13.34 kB 56.03 kB
/ui/thumbnail 9.77 kB 56.03 kB
/ui/time 10.60 kB 56.03 kB
/ui/time-slider 16.17 kB 56.03 kB
/ui/title 7.88 kB 56.03 kB
/ui/tooltip 9.98 kB 56.03 kB
/ui/volume-indicator 13.39 kB 56.03 kB
/ui/volume-popover 15.53 kB 56.03 kB
/ui/volume-slider 12.96 kB 56.03 kB
🧩 @videojs/core — no changes
Entries (76)
Entry Initial Lazy
. 13.41 kB —
/dom 23.48 kB 56.03 kB
/vjsc 1.90 kB —
/i18n 3.21 kB 56.03 kB
/i18n/locales/all 33.91 kB —
/i18n/locales/ar 1.16 kB —
/i18n/locales/az 1.08 kB —
/i18n/locales/bg 1.29 kB —
/i18n/locales/bn 1.25 kB —
/i18n/locales/bs 1.02 kB —
/i18n/locales/ca 1.04 kB —
/i18n/locales/cs 1.10 kB —
/i18n/locales/cy 1.02 kB —
/i18n/locales/da 984 B —
/i18n/locales/de 1.06 kB —
/i18n/locales/el 1.42 kB —
/i18n/locales/en 801 B —
/i18n/locales/es 999 B —
/i18n/locales/et 1.02 kB —
/i18n/locales/eu 1.04 kB —
/i18n/locales/fa 1.21 kB —
/i18n/locales/fi 1.05 kB —
/i18n/locales/fr 1.01 kB —
/i18n/locales/gd 1.09 kB —
/i18n/locales/gl 1017 B —
/i18n/locales/he 1.10 kB —
/i18n/locales/hi 1.25 kB —
/i18n/locales/hr 1.05 kB —
/i18n/locales/hu 1.10 kB —
/i18n/locales/id 953 B —
/i18n/locales/it 1.01 kB —
/i18n/locales/ja 1.16 kB —
/i18n/locales/ko 1.08 kB —
/i18n/locales/lt 1.04 kB —
/i18n/locales/lv 1.09 kB —
/i18n/locales/mr 1.23 kB —
/i18n/locales/nb 990 B —
/i18n/locales/ne 1.23 kB —
/i18n/locales/nl 1.01 kB —
/i18n/locales/nn 983 B —
/i18n/locales/oc 1.05 kB —
/i18n/locales/pl 1.11 kB —
/i18n/locales/pt 1.02 kB —
/i18n/locales/pt-BR 1.02 kB —
/i18n/locales/pt-PT 1.02 kB —
/i18n/locales/ro 1.04 kB —
/i18n/locales/ru 1.36 kB —
/i18n/locales/sk 1.10 kB —
/i18n/locales/sl 1.04 kB —
/i18n/locales/sr 1.05 kB —
/i18n/locales/sv 1.01 kB —
/i18n/locales/te 1.29 kB —
/i18n/locales/th 1.20 kB —
/i18n/locales/tr 1.00 kB —
/i18n/locales/uk 1.37 kB —
/i18n/locales/vi 1.10 kB —
/i18n/locales/zh 1.01 kB —
/i18n/locales/zh-CN 1.01 kB —
/i18n/locales/zh-TW 1.02 kB —
/i18n/text/airplay 101 B —
/i18n/text/buttons 137 B —
/i18n/text/captions 93 B —
/i18n/text/cast 114 B —
/i18n/text/common 90 B —
/i18n/text/container 75 B —
/i18n/text/errors 285 B —
/i18n/text/fullscreen 98 B —
/i18n/text/live 126 B —
/i18n/text/menu 249 B —
/i18n/text/pip 101 B —
/i18n/text/playback 80 B —
/i18n/text/seek 105 B —
/i18n/text/slider 65 B —
/i18n/text/status 222 B —
/i18n/text/time 322 B —
/i18n/text/volume 133 B —
🏷️ @videojs/element — no changes
Entries (2)
Entry Initial
. 1.05 kB
/context 943 B
📦 @videojs/store — no changes
Entries (3)
Entry Initial
. 1.72 kB
/html 703 B
/react 511 B
🔧 @videojs/utils — no changes
Entries (13)
Entry Initial
/array 271 B
/dom 5.25 kB
/events 320 B
/function 414 B
/i18n 249 B
/jwt 176 B
/object 535 B
/predicate 297 B
/percent 281 B
/string 239 B
/style 212 B
/time 1018 B
/number 199 B
📦 @videojs/cdn — no changes
📦 @videojs/cloudflare-video — no changes
📦 @videojs/dash-video — no changes
📦 @videojs/google-cast — no changes
📦 @videojs/hlsjs-video — no changes
📦 @videojs/media — no changes
Entries (3)
Entry Initial
. 1.29 kB
/dom 4.12 kB
/media-tracks 2.05 kB
📦 @videojs/mux — no changes
📦 @videojs/mux-audio — no changes
Entries (2)
Entry Initial
. 136.12 kB
/spf 22.85 kB
📦 @videojs/mux-data — no changes
📦 @videojs/mux-video — no changes
Entries (2)
Entry Initial
. 136.12 kB
/spf 33.00 kB
📦 @videojs/native-hls-video — no changes
📦 @videojs/shaka-video — no changes

📦 @videojs/spf

Path Base initial PR initial Initial diff Lazy diff
/moq 27.45 kB 28.58 kB +1.13 kB (+4.1%) —
Entries (8)
Entry Initial
. 4.55 kB
/dom 7.67 kB
/hls 28.22 kB
/media-tracks 607 B
/moq 28.58 kB
/hls-background-video 16.51 kB
/hls-audio 21.36 kB
/hls-video 31.73 kB
📦 @videojs/spotify-audio — no changes
📦 @videojs/tiktok-video — no changes
📦 @videojs/twitch-video — no changes
📦 @videojs/other — no changes
Entries (3)
Entry Initial Lazy
video.js 71.83 kB 56.03 kB
video.js/package.json 608 B —
video.js/errors 1.03 kB —
📦 @videojs/vimeo-video — no changes
📦 @videojs/wistia-video — no changes
Entries (2)
Entry Initial
. 1.91 kB
/helpers 1.77 kB
📦 @videojs/youtube-video — no changes

ℹ️ How to interpret

Each entry is independently bundled, minified, and brotli-compressed. Initial size includes its static import graph; lazy dynamic chunks are reported separately.

Entries are not additive because their dependency graphs overlap. Preset rows represent realistic combined bundles.

Changes of 300 B or less across initial, lazy, and total size are collapsed, not discarded.

Run pnpm size locally to check current initial sizes.

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 7 files

Tip: Get a Slack DM when cubic finishes reviewing your PRs. Connect Slack

View guided diff | Turn on auto-fix | Re-trigger cubic

mmcc added 5 commits October 19, 2026 18:22
…ause

Run the renderer's clock and fill-stall timer on AudioContext.currentTime,
which stops when the adapter suspends the context, instead of
performance.now(); scope each input's clock so reports from a removed input
are ignored; report output.connect failures; guard the BaseAudioContext
global in the adapter.

Refs #66
…nd pause

Hold the underrun position as a floor until the refill's future-dated anchor
reaches it, and time the core's reports on context time (localNow) so its
render-clock calibration stops across a suspend instead of jumping the clock
by the pause on resume.

Refs #66
…gth ignores loss gaps

Take the recovery floor from what the clock read when the hold released,
not the render-side dry point, and read Opus packet durations from the TOC
byte (else the shortest step between frames) so a gap of lost packets does
not extend pushed audio past where it ends.

Refs #66
… reports

A placed clock now stops at the end of the audio pushed and holds there until
the core plays, with the first real report floored like an underrun recovery.
The underrun hold ends only once the core has reported itself stopped (or on a
report clearly past the dry point), so a late report of the old tail no longer
releases it.

Refs #66
…efill

Count underruns on the renderer's own dry edges, as audio-renderer does,
instead of the core's counter, which skips stalls longer than its jitter
ceiling that adaptLatencyTarget still needs. Treat a frozen placed clock as
filling so the fill-stall rescue can start the worklet across a packet gap.

Refs #66

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 2 files (changes from recent commits).

Tip: Review your code locally with the cubic CLI to iterate faster.

View guided diff | Turn on auto-fix | Re-trigger cubic

Detect a pending dry edge in setTrack before the input and timeline are
reset, so an underrun between the last tick and the switch still counts.

Refs #66
@mmcc
mmcc merged commit 9ca2548 into mmcc/moq Oct 19, 2026
22 of 24 checks passed
@mmcc
mmcc deleted the feat/moq-worklet-audio-renderer branch October 19, 2026 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant