Repository navigation
fix(spf): frame INCLUDE_PROPERTIES as a bare uint8 for moq-relay 0.17.0 - #59
Conversation
moq-relay 0.17.0 (moq-dev/moq#4610) decodes the 0x35 subscribe parameter as a raw byte, matching draft-20 §10.2.21; earlier relays framed it length-prefixed by type parity. Encode and decode it as one byte (0 or 1). Closes #58
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
📦 Bundle Size Report🎨 @videojs/html — 1 small size change
Presets (7)
Media (19)
Players (5)
Skins (29)
UI Components (62)
⚛️ @videojs/react — no changesPresets (7)
Media (22)
Extensions (2)
Players (5)
Skins (18)
UI Components (39)
🧩 @videojs/core — no changesEntries (76)
🏷️ @videojs/element — no changesEntries (2)
📦 @videojs/store — no changesEntries (3)
🔧 @videojs/utils — no changesEntries (13)
📦 @videojs/cdn — no changes📦 @videojs/cloudflare-video — no changes📦 @videojs/dash-video — no changes📦 @videojs/google-cast — no changes📦 @videojs/hlsjs-video — no changes📦 @videojs/media — no changesEntries (3)
📦 @videojs/mux — no changes📦 @videojs/mux-audio — no changesEntries (2)
📦 @videojs/mux-data — no changes📦 @videojs/mux-video — no changesEntries (2)
📦 @videojs/native-hls-video — no changes📦 @videojs/shaka-video — no changes📦 @videojs/spf — 1 small size change
Entries (8)
📦 @videojs/spotify-audio — no changes📦 @videojs/tiktok-video — no changes📦 @videojs/twitch-video — no changes📦 @videojs/other — no changesEntries (3)
📦 @videojs/vimeo-video — no changes📦 @videojs/wistia-video — no changesEntries (2)
📦 @videojs/youtube-video — no changesℹ️ How to interpretEach entry is independently bundled, minified, and brotli-compressed. Initial size includes its static import graph; lazy dynamic chunks are reported separately. Entries are not additive because their dependency graphs overlap. Preset rows represent realistic combined bundles. Changes of 300 B or less across initial, lazy, and total size are collapsed, not discarded. Run |
There was a problem hiding this comment.
3 issues found across 3 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name=".agents/plans/moq-transport-20-migration.md">
<violation number="1" location=".agents/plans/moq-transport-20-migration.md:24">
P3: This PR keeps editing `.agents/plans/moq-transport-20-migration.md`, but per AGENTS.md and `.agents/plans/README.md` plan files are temporary and must be deleted before merge. Move anything durable into `internal/decisions/` or `internal/design/` and delete this file as part of the migration PR, or at least before this PR merges.</violation>
<violation number="2" location=".agents/plans/moq-transport-20-migration.md:171">
P3: This leaves the framing description self-contradictory: the preceding sentence still says INCLUDE_PROPERTIES is length-prefixed, while this note says it is a bare byte. Mark the length-prefixed framing as historical.</violation>
</file>
<file name="packages/spf/src/network/moqt/tests/control-messages.test.ts">
<violation number="1" location="packages/spf/src/network/moqt/tests/control-messages.test.ts:400">
P2: The updated test no longer verifies valid `includeProperties: 1`; a regression that rejects `1` or retains its old framing would pass. Add encode and decode assertions for the bare `0x01` value.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
Closes #58
Why
moq-relay 0.17.0 (moq-dev/moq#4610) decodes the INCLUDE_PROPERTIES subscribe parameter (0x35) as
Option<bool>, which on draft-17+ is a single raw byte. Earlier relays (≤0.15.8) wrapped it in a length prefix by the odd-type parity rule, and our codec matched that. mux.global now runs 0.17.0, so a subscription that setsincludeProperties, or a relay forwarding the opt-out to the publisher, would hit a protocol error.Draft-20 §10.2.21 also calls the value a uint8, so this brings the codec in line with both the spec and the relay.
Change
collectParameterEntries/decodeMessageParameters: 0x35 is now one byte; values other than 0/1 are still rejected.01 35 00) and update the parameter-alignment vector after LARGEST_OBJECT..agents/plans/moq-transport-20-migration.md: replaced the "keep it length-prefixed" notes.There's no fallback for older relays: one byte can't reliably tell you which framing the peer used. Nothing in the player or publisher sets
includePropertiestoday, so existing sessions don't change.Verification
pnpm -F @videojs/spf test: 136 files / 2399 tests pass.rs/moq-net/src/ietf/{subscribe,parameters}.rsatmoq-relay-v0.17.0(bool param = raw byte from draft-17).🤖 Generated with Claude Code
Summary by cubic
Changes the
INCLUDE_PROPERTIES(0x35) subscribe parameter to encode and decode as a bare uint8 instead of a length-prefixed byte, matching moq-relay 0.17.0 (moq-dev/moq#4610) and draft-20 §10.2.21. Values other than 0/1 are still rejected.includeProperties, so existing sessions are unaffected.Closes #58.
Written for commit 67ddf56. Summary will update on new commits.