Repository navigation
refactor(core): rename publisher UI modules to the upstream file convention - #56
Conversation
…ention Moves the publisher's core, HTML, and React UI modules to core.ts/data.ts, element.ts, and component.tsx (tests included), matching their upstream siblings. Exports and tag names are unchanged. Closes #55
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
📦 Bundle Size Report🎨 @videojs/html — no changesPresets (7)
Media (20)
Players (6)
Skins (33)
UI Components (73)
⚛️ @videojs/react — no changesPresets (7)
Media (23)
Extensions (2)
Players (5)
Skins (21)
UI Components (50)
🧩 @videojs/core — no changesEntries (77)
🏷️ @videojs/element — no changesEntries (2)
📦 @videojs/store — no changesEntries (3)
🔧 @videojs/utils — no changesEntries (13)
📦 @videojs/cdn — no changes📦 @videojs/cloudflare-video — no changes📦 @videojs/dash-video — no changes📦 @videojs/google-cast — no changes📦 @videojs/hlsjs-video — no changes📦 @videojs/media — no changesEntries (3)
📦 @videojs/mux — no changes📦 @videojs/mux-audio — no changesEntries (2)
📦 @videojs/mux-data — no changes📦 @videojs/mux-video — no changesEntries (2)
📦 @videojs/native-hls-video — no changes📦 @videojs/shaka-video — no changes📦 @videojs/spf — no changesEntries (10)
📦 @videojs/spotify-audio — no changes📦 @videojs/tiktok-video — no changes📦 @videojs/twitch-video — no changes📦 @videojs/other — no changesEntries (3)
📦 @videojs/vimeo-video — no changes📦 @videojs/wistia-video — no changesEntries (2)
📦 @videojs/youtube-video — no changesℹ️ How to interpretEach entry is independently bundled, minified, and brotli-compressed. Initial size includes its static import graph; lazy dynamic chunks are reported separately. Entries are not additive because their dependency graphs overlap. Preset rows represent realistic combined bundles. Changes of 300 B or less across initial, lazy, and total size are collapsed, not discarded. Run |
There was a problem hiding this comment.
All reported issues were addressed across 88 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
The sandbox treats every html-/react- template as a media matrix page, so react-moq-publisher failed its media table check. Rename it to moq-publisher-react like the other one-off templates, and point the design record's implementation glob at the renamed core.ts modules.
Closes #55.
Moves the 11 publisher UI modules (
camera-button,camera-radio-group,capture-placeholder,connection-indicator,enable-devices-button,mic-button,mic-radio-group,publish-badge,publish-button,publish-timer,screen-share-button) to the same file names as their upstream siblings:<name>-core.ts/<name>-data-attrs.ts→core.ts/data.ts, andtests/core.test.ts<name>-element.ts→element.ts, andtests/element.test.ts<name>.tsx→component.tsx, andtests/component.test.tsxOnly file paths and imports change. Public exports and tag names stay the same. This is the first step for #54: VJSC finds components through
src/core/ui/*/component.ts, which the skin port will add next to these files.Verification
pnpm build:packages, then a cleanpnpm typecheckandpnpm lint@videojs/core1770 tests,@videojs/html543,@videojs/react633: all pass🤖 Generated with Claude Code
Summary by cubic
Renames the 11 publisher UI modules to the upstream file convention so VJSC tooling can discover them (first step for #54). Closes #55.
packages/core:<name>-core.ts/<name>-data-attrs.ts→core.ts/data.tspackages/html:<name>-element.ts→element.tspackages/react:<name>.tsx→component.tsxOnly file paths and import statements change; public exports and custom element tag names are unchanged.
Also renames the React publisher sandbox template to
moq-publisher-reactso it isn't treated as a media matrix page, and points the design record's implementation glob at the renamedcore.tsmodules.Written for commit f7f1019. Summary will update on new commits.