Skip to content

fix(spf): align publisher framing and tests with relay 0.14.17 - #48

Merged
mmcc merged 1 commit into
mmcc/moq-publisherfrom
fix/moq-relay-0.14.17-publisher
Sep 16, 2026
Merged

mmcc merged 1 commit into
mmcc/moq-publisherfrom
fix/moq-relay-0.14.17-publisher

Conversation

@mmcc

@mmcc mmcc commented Sep 16, 2026 •

Copy link
Copy Markdown
Owner

Refs #45
Related subscriber PR: #47
Fill-serving follow-up: #46

Summary

Once a track has content, the publisher includes LARGEST_OBJECT in SUBSCRIBE_OK and REQUEST_OK. Its old length prefix is incompatible with moq-relay 0.14.17. Encode and decode Locations as two bare varints, and update the relay test hub to exercise the new upstream pull.

Changes

  • Pin fixed wire vectors for Locations and response messages, including trailing parameters/properties and truncation. INCLUDE_PROPERTIES remains length-prefixed.
  • Model relay 0.14.17's Next Object + FILL_PARAMETERS StartGroup=1 pull, including the observed subscriber priority.
  • Observe fill headers through reset/FIN and test pulls before and after content exists, followed by live delivery. The zero-buffer test transport exposes commit because writes resolve only after the peer reads them.
  • Update stale comments and migration notes, including the coordinated relay cutover.

Known limitation, tracked separately in #46: the existing publisher rejects nonempty fills when the browser lacks writer.commit(). This PR covers the framing fix and the existing reliable-reset path; it does not implement browser-compatible fill serving. Older relays' length-prefixed Locations remain incompatible, so coordinate deployment with the relay upgrade.

Testing

  • Network, playback behavior, and publisher suites: 836 tests passed.
  • Four browser cross-engine tests passed.
  • Relay-hub suite passed after updating the observed upstream priority.
  • SPF build, SPF project type check, changed-file lint/format checks, and pnpm check:workspace passed.
  • Live WebTransport pass with fix(spf): align subscriber location framing with relay 0.14.17 #47 against moqdev/moq-relay:0.14.17: initial delivery and a late subscriber receiving Largest Object {255,128} plus 129 cached objects succeeded.
  • Live publisher re-subscription after viewer cancellation reached the new fill request but was rejected with NOT_SUPPORTED: fill requires reliable stream reset in Chromium 147.0.7727.15 / Playwright 1.59.1, including with experimental web-platform features. Full live publisher re-subscription remains unverified until Serve MoQ Publisher Fills Without Requiring Browser Reliable Reset Support #46 is addressed; the protocol test used synthetic payloads.

Summary by cubic

Fixes the LARGEST_OBJECT framing mismatch from #45: the publisher now encodes and decodes it as two bare varints in SUBSCRIBE_OK and REQUEST_OK, matching moq-relay 0.14.17. Older relays' length-prefixed Locations remain incompatible, so deploy this with the relay upgrade.

Changes

  • Pins fixed wire vectors for SUBSCRIBE_OK, REQUEST_OK, trailing parameters/properties, and truncation; INCLUDE_PROPERTIES stays length-prefixed.
  • Updates the relay test hub to model 0.14.17's upstream pull: Next Object plus FILL_PARAMETERS StartGroup=1, with subscriber priority 255.
  • Adds hub tests for pulls before and after content exists, covering fill header reset and live delivery after the fill.
  • Browser-based fill serving remains blocked on writer.commit() (Serve MoQ Publisher Fills Without Requiring Browser Reliable Reset Support #46); this PR keeps the existing reliable-reset path.

Written for commit 73f42e4. Summary will update on new commits.

Review in cubic

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 73f42e4a90

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".


Temporary implementation notes — delete before merge per `AGENTS.md`.

**Issue #45 verification (2026-09-16, moq-relay 0.14.17):** the shared codec

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Remove the temporary migration plan before merge

Do not expand and retain this planning file: the repository guide explicitly classifies .agents/plans/ as temporary implementation notes that must be deleted before merge. Keeping it also preserves stale implementation-planning claims, such as the later statement that fills are not needed for the relay path, despite this change documenting that relay 0.14.17 now requests them; delete the plan and move only explicitly requested durable rationale to an appropriate record.

AGENTS.md reference: AGENTS.md:L64-L70

Useful? React with 👍 / 👎.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-16T16:49:58.470524Z 73f42e4 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

Copy link
Copy Markdown

📦 Bundle Size Report

🎨 @videojs/html — 2 small size changes
Path Base initial PR initial Initial diff Lazy diff
/media/moq-publish-video 25.03 kB 25.04 kB +11 B (+0.0%) —
/media/simple-moq-video 28.67 kB 28.63 kB -45 B (-0.2%) —
Presets (7)
Entry Initial Lazy
/video (default) 62.57 kB 68.28 kB
/video (default + hls) 201.69 kB 68.28 kB
/video (minimal) 62.31 kB 68.28 kB
/video (minimal + hls) 201.23 kB 68.28 kB
/audio (default) 52.38 kB 68.28 kB
/audio (minimal) 48.31 kB 68.28 kB
/background 12.24 kB 68.28 kB
Media (21)
Entry Initial
/media/mux-video 142.33 kB
/media/mux-audio 142.05 kB
/media/background-video 1.16 kB
/media/cloudflare-video 6.22 kB
/media/dash-video 211.72 kB
/media/google-cast 6.52 kB
/media/hls-audio 22.14 kB
/media/hls-background-video 16.86 kB
/media/hls-video 28.21 kB
/media/hlsjs-video 141.03 kB
/media/moq-publish-video 25.04 kB
/media/mux-background-video 16.87 kB
/media/mux-data 26.70 kB
/media/native-hls-video 7.51 kB
/media/shaka-video 199.21 kB
/media/simple-moq-video 28.63 kB
/media/spotify-audio 6.24 kB
/media/tiktok-video 6.29 kB
/media/twitch-video 6.19 kB
/media/vimeo-video 13.03 kB
/media/youtube-video 6.79 kB
Players (6)
Entry Initial Lazy
/video/player 9.65 kB 68.28 kB
/audio/player 6.10 kB 68.28 kB
/background/player 4.46 kB 68.28 kB
/live-video/player 9.02 kB 68.28 kB
/live-audio/player 6.11 kB 68.28 kB
/publisher/player 6.85 kB 68.28 kB
Skins (41)
Entry Type Initial Lazy
/video/minimal-skin.css css 6.51 kB —
/video/skin.css css 6.32 kB —
/video/minimal-skin js 60.85 kB 68.28 kB
/video/minimal-skin.tailwind js 61.20 kB 68.28 kB
/video/minimal-skin2 js 7.07 kB —
/video/skin js 61.03 kB 68.28 kB
/video/skin.tailwind js 61.37 kB 68.28 kB
/video/skin2 js 6.92 kB —
/audio/minimal-skin.css css 4.88 kB —
/audio/skin.css css 4.81 kB —
/audio/minimal-skin js 46.73 kB 68.28 kB
/audio/minimal-skin.tailwind js 47.07 kB 68.28 kB
/audio/minimal-skin2 js 5.28 kB —
/audio/skin js 50.85 kB 68.28 kB
/audio/skin.tailwind js 51.25 kB 68.28 kB
/audio/skin2 js 5.25 kB —
/background/skin.css css 145 B —
/background/skin js 10.49 kB 68.28 kB
/background/skin2 js 190 B —
/live-video/minimal-skin.css css 6.51 kB —
/live-video/skin.css css 6.32 kB —
/live-video/minimal-skin js 54.71 kB 68.28 kB
/live-video/minimal-skin.tailwind js 54.79 kB 68.28 kB
/live-video/minimal-skin2 js 7.07 kB —
/live-video/skin js 57.55 kB 68.28 kB
/live-video/skin.tailwind js 57.65 kB 68.28 kB
/live-video/skin2 js 6.92 kB —
/live-audio/minimal-skin.css css 4.88 kB —
/live-audio/skin.css css 4.81 kB —
/live-audio/minimal-skin js 40.06 kB 68.28 kB
/live-audio/minimal-skin.tailwind js 39.17 kB 68.28 kB
/live-audio/minimal-skin2 js 5.28 kB —
/live-audio/skin js 43.84 kB 68.28 kB
/live-audio/skin.tailwind js 43.12 kB 68.28 kB
/live-audio/skin2 js 5.25 kB —
/publisher/skin.css css 4.90 kB —
/publisher/skin js 45.74 kB 68.28 kB
/publisher/skin.tailwind js 45.74 kB 68.28 kB
/publisher/skin2 js 5.29 kB —
/global.css css 195 B —
/shared.css css 118 B —
UI Components (60)
Entry Initial Lazy
/ui/airplay-button 11.92 kB 68.28 kB
/ui/alert-dialog 9.13 kB 68.28 kB
/ui/audio-track-radio-group 12.05 kB 68.28 kB
/ui/buffering-indicator 9.32 kB 68.28 kB
/ui/camera-button 12.06 kB 68.28 kB
/ui/camera-radio-group 12.19 kB 68.28 kB
/ui/captions-button 12.15 kB 68.28 kB
/ui/captions-radio-group 12.13 kB 68.28 kB
/ui/capture-placeholder 10.30 kB 68.28 kB
/ui/cast-button 11.90 kB 68.28 kB
/ui/connection-indicator 10.17 kB 68.28 kB
/ui/container 10.19 kB 68.28 kB
/ui/controls 9.54 kB 68.28 kB
/ui/controls-backdrop 1.69 kB 68.28 kB
/ui/controls-content 1.67 kB 68.28 kB
/ui/dialog 9.07 kB 68.28 kB
/ui/dialog-backdrop 1.70 kB 68.28 kB
/ui/dialog-close 2.01 kB 68.28 kB
/ui/dialog-description 1.69 kB 68.28 kB
/ui/dialog-popup 1.87 kB 68.28 kB
/ui/dialog-title 1.70 kB 68.28 kB
/ui/enable-devices-button 12.12 kB 68.28 kB
/ui/error-dialog 13.41 kB 68.28 kB
/ui/fullscreen-button 11.85 kB 68.28 kB
/ui/gesture 10.13 kB 68.28 kB
/ui/hotkey 10.57 kB 68.28 kB
/ui/menu 20.74 kB 68.28 kB
/ui/mic-button 12.05 kB 68.28 kB
/ui/mic-radio-group 12.18 kB 68.28 kB
/ui/mute-button 11.90 kB 68.28 kB
/ui/pip-button 11.87 kB 68.28 kB
/ui/play-button 11.86 kB 68.28 kB
/ui/playback-rate-button 11.97 kB 68.28 kB
/ui/playback-rate-radio-group 12.04 kB 68.28 kB
/ui/popover 8.53 kB 68.28 kB
/ui/poster 9.38 kB 68.28 kB
/ui/publish-badge 10.27 kB 68.28 kB
/ui/publish-button 10.67 kB 68.28 kB
/ui/publish-timer 10.84 kB 68.28 kB
/ui/quality-radio-group 12.64 kB 68.28 kB
/ui/screen-share-button 12.08 kB 68.28 kB
/ui/seek-button 11.91 kB 68.28 kB
/ui/seek-indicator 13.23 kB 68.28 kB
/ui/seek-indicator-value 1.10 kB —
/ui/slider 12.79 kB 68.28 kB
/ui/status-announcer 11.32 kB 68.28 kB
/ui/status-indicator 13.58 kB 68.28 kB
/ui/status-indicator-value 1.10 kB —
/ui/thumbnail 10.50 kB 68.28 kB
/ui/time 11.58 kB 68.28 kB
/ui/time-slider 15.71 kB 68.28 kB
/ui/time-slider-chapter-title 9.48 kB 68.28 kB
/ui/time-slider-chapters 10.44 kB 68.28 kB
/ui/title 8.88 kB 68.28 kB
/ui/tooltip 9.92 kB 68.28 kB
/ui/volume-indicator 13.60 kB 68.28 kB
/ui/volume-indicator-fill 1.11 kB —
/ui/volume-indicator-value 1.10 kB —
/ui/volume-popover 15.43 kB 68.28 kB
/ui/volume-slider 13.44 kB 68.28 kB
⚛️ @videojs/react — 1 small size change
Path Base initial PR initial Initial diff Lazy diff
/media/moq-publish-video 23.24 kB 23.18 kB -59 B (-0.2%) —
Presets (7)
Entry Initial Lazy
/video (default) 48.59 kB 68.28 kB
/video (default + hls) 186.43 kB 68.28 kB
/video (minimal) 48.57 kB 68.28 kB
/video (minimal + hls) 186.41 kB 68.28 kB
/audio (default) 37.88 kB 68.28 kB
/audio (minimal) 37.93 kB 68.28 kB
/background 580 B 68.28 kB
Media (24)
Entry Initial
/media/mux-video/hls-js 140.62 kB
/media/mux-video/spf 27.52 kB
/media/mux-audio/hls-js 140.46 kB
/media/mux-audio/spf 21.41 kB
/media/background-video 402 B
/media/cloudflare-video 4.35 kB
/media/dash-video 210.29 kB
/media/google-cast 5.34 kB
/media/hls-audio 20.45 kB
/media/hls-background-video 16.44 kB
/media/hls-video 26.49 kB
/media/hlsjs-video 139.58 kB
/media/moq-publish-video 23.18 kB
/media/mux-audio 140.44 kB
/media/mux-background-video 16.43 kB
/media/mux-data 25.49 kB
/media/mux-video 140.62 kB
/media/native-hls-video 5.76 kB
/media/shaka-video 197.52 kB
/media/spotify-audio 4.22 kB
/media/tiktok-video 4.18 kB
/media/twitch-video 4.30 kB
/media/vimeo-video 11.21 kB
/media/youtube-video 4.86 kB
Players (5)
Entry Initial Lazy
/video/player 7.51 kB 68.28 kB
/audio/player 3.95 kB 68.28 kB
/background/player 2.27 kB 68.28 kB
/live-video/player 6.91 kB 68.28 kB
/live-audio/player 3.96 kB 68.28 kB
Skins (29)
Entry Type Initial Lazy
/video/minimal-skin.css css 6.40 kB —
/video/skin.css css 6.20 kB —
/video/minimal-skin js 48.48 kB 68.28 kB
/video/minimal-skin.tailwind js 55.46 kB 68.28 kB
/video/skin js 48.49 kB 68.28 kB
/video/skin.tailwind js 55.30 kB 68.28 kB
/audio/minimal-skin.css css 4.73 kB —
/audio/skin.css css 4.66 kB —
/audio/minimal-skin js 37.81 kB 68.28 kB
/audio/minimal-skin.tailwind js 42.93 kB 68.28 kB
/audio/skin js 37.79 kB 68.28 kB
/audio/skin.tailwind js 42.92 kB 68.28 kB
/background/skin.css css 90 B —
/background/skin js 277 B —
/live-video/minimal-skin.css css 6.40 kB —
/live-video/skin.css css 6.20 kB —
/live-video/minimal-skin js 40.62 kB 68.28 kB
/live-video/minimal-skin.tailwind js 47.27 kB 68.28 kB
/live-video/skin js 40.64 kB 68.28 kB
/live-video/skin.tailwind js 47.18 kB 68.28 kB
/live-audio/minimal-skin.css css 4.73 kB —
/live-audio/skin.css css 4.66 kB —
/live-audio/minimal-skin js 29.66 kB 68.28 kB
/live-audio/minimal-skin.tailwind js 33.58 kB 68.28 kB
/live-audio/skin js 29.69 kB 68.28 kB
/live-audio/skin.tailwind js 33.71 kB 68.28 kB
/publisher/skin.css css 4.77 kB —
/publisher/skin js 30.93 kB 68.28 kB
/publisher/skin.tailwind js 35.69 kB 68.28 kB
UI Components (50)
Entry Initial Lazy
/ui/airplay-button 11.04 kB 68.28 kB
/ui/alert-dialog 4.41 kB 68.28 kB
/ui/audio-track 8.65 kB 68.28 kB
/ui/audio-track-radio-group 9.82 kB 68.28 kB
/ui/buffering-indicator 8.47 kB 68.28 kB
/ui/camera-button 11.17 kB 68.28 kB
/ui/camera-radio-group 8.65 kB 68.28 kB
/ui/captions-button 11.02 kB 68.28 kB
/ui/captions-radio-group 9.92 kB 68.28 kB
/ui/capture-placeholder 9.20 kB 68.28 kB
/ui/cast-button 11.02 kB 68.28 kB
/ui/connection-indicator 9.14 kB 68.28 kB
/ui/controls 8.26 kB 68.28 kB
/ui/dialog 4.44 kB 68.28 kB
/ui/enable-devices-button 11.27 kB 68.28 kB
/ui/error-dialog 12.19 kB 68.28 kB
/ui/fullscreen-button 10.98 kB 68.28 kB
/ui/gesture 8.55 kB 68.28 kB
/ui/hotkey 8.99 kB 68.28 kB
/ui/live-button 9.45 kB 68.28 kB
/ui/menu 19.67 kB 68.28 kB
/ui/mic-button 11.18 kB 68.28 kB
/ui/mic-radio-group 8.65 kB 68.28 kB
/ui/mute-button 11.04 kB 68.28 kB
/ui/pip-button 10.98 kB 68.28 kB
/ui/play-button 10.96 kB 68.28 kB
/ui/playback-rate 8.69 kB 68.28 kB
/ui/playback-rate-button 10.96 kB 68.28 kB
/ui/playback-rate-radio-group 9.86 kB 68.28 kB
/ui/popover 8.12 kB 68.28 kB
/ui/poster 8.25 kB 68.28 kB
/ui/publish-badge 9.19 kB 68.28 kB
/ui/publish-button 9.71 kB 68.28 kB
/ui/publish-timer 9.73 kB 68.28 kB
/ui/quality 9.14 kB 68.28 kB
/ui/quality-radio-group 10.30 kB 68.28 kB
/ui/screen-share-button 11.20 kB 68.28 kB
/ui/seek-button 10.99 kB 68.28 kB
/ui/seek-indicator 12.52 kB 68.28 kB
/ui/slider 13.36 kB 68.28 kB
/ui/status-announcer 10.77 kB 68.28 kB
/ui/status-indicator 12.80 kB 68.28 kB
/ui/thumbnail 9.37 kB 68.28 kB
/ui/time 10.43 kB 68.28 kB
/ui/time-slider 14.87 kB 68.28 kB
/ui/title 7.94 kB 68.28 kB
/ui/tooltip 8.90 kB 68.28 kB
/ui/volume-indicator 12.92 kB 68.28 kB
/ui/volume-popover 14.89 kB 68.28 kB
/ui/volume-slider 12.79 kB 68.28 kB
🧩 @videojs/core — no changes
Entries (77)
Entry Initial Lazy
. 14.39 kB —
/dom 22.82 kB 68.28 kB
/vjsc 1.74 kB —
/i18n 3.43 kB 68.28 kB
/i18n/locales/all 35.40 kB —
/i18n/locales/ar 1.45 kB —
/i18n/locales/az 1.31 kB —
/i18n/locales/bg 1.53 kB —
/i18n/locales/bn 1.46 kB —
/i18n/locales/bs 1.23 kB —
/i18n/locales/ca 1.29 kB —
/i18n/locales/cs 1.29 kB —
/i18n/locales/cy 1.24 kB —
/i18n/locales/da 1.20 kB —
/i18n/locales/de 1.31 kB —
/i18n/locales/el 1.74 kB —
/i18n/locales/en 993 B —
/i18n/locales/es 1.21 kB —
/i18n/locales/et 1.27 kB —
/i18n/locales/eu 1.24 kB —
/i18n/locales/fa 1.45 kB —
/i18n/locales/fi 1.26 kB —
/i18n/locales/fr 1.29 kB —
/i18n/locales/gd 1.32 kB —
/i18n/locales/gl 1.21 kB —
/i18n/locales/he 1.37 kB —
/i18n/locales/hi 1.54 kB —
/i18n/locales/hr 1.25 kB —
/i18n/locales/hu 1.31 kB —
/i18n/locales/id 1.11 kB —
/i18n/locales/it 1.22 kB —
/i18n/locales/ja 1.41 kB —
/i18n/locales/ko 1.36 kB —
/i18n/locales/lt 1.24 kB —
/i18n/locales/lv 1.30 kB —
/i18n/locales/mr 1.54 kB —
/i18n/locales/nb 1.18 kB —
/i18n/locales/ne 1.52 kB —
/i18n/locales/nl 1.22 kB —
/i18n/locales/nn 1.18 kB —
/i18n/locales/oc 1.29 kB —
/i18n/locales/pl 1.36 kB —
/i18n/locales/pt 1.25 kB —
/i18n/locales/pt-BR 1.25 kB —
/i18n/locales/pt-PT 1.23 kB —
/i18n/locales/ro 1.28 kB —
/i18n/locales/ru 1.63 kB —
/i18n/locales/sk 1.32 kB —
/i18n/locales/sl 1.26 kB —
/i18n/locales/sr 1.29 kB —
/i18n/locales/sv 1.22 kB —
/i18n/locales/te 1.55 kB —
/i18n/locales/th 1.53 kB —
/i18n/locales/tr 1.30 kB —
/i18n/locales/uk 1.64 kB —
/i18n/locales/vi 1.32 kB —
/i18n/locales/zh 1.23 kB —
/i18n/locales/zh-CN 1.23 kB —
/i18n/locales/zh-TW 1.24 kB —
/i18n/text/airplay 101 B —
/i18n/text/buttons 137 B —
/i18n/text/captions 93 B —
/i18n/text/cast 114 B —
/i18n/text/common 90 B —
/i18n/text/container 75 B —
/i18n/text/errors 285 B —
/i18n/text/fullscreen 98 B —
/i18n/text/live 126 B —
/i18n/text/menu 249 B —
/i18n/text/pip 101 B —
/i18n/text/playback 80 B —
/i18n/text/publish 451 B —
/i18n/text/seek 105 B —
/i18n/text/slider 65 B —
/i18n/text/status 222 B —
/i18n/text/time 280 B —
/i18n/text/volume 133 B —
🏷️ @videojs/element — no changes
Entries (2)
Entry Initial
. 1.05 kB
/context 943 B
📦 @videojs/store — no changes
Entries (3)
Entry Initial
. 1.72 kB
/html 703 B
/react 365 B
🔧 @videojs/utils — no changes
Entries (13)
Entry Initial
/array 271 B
/dom 5.02 kB
/events 320 B
/function 386 B
/i18n 249 B
/jwt 176 B
/object 535 B
/predicate 297 B
/percent 281 B
/string 239 B
/style 212 B
/time 976 B
/number 199 B

📦 @videojs/media

Path Base initial PR initial Initial diff Lazy diff
/dom/dash 209.83 kB 3.28 kB -206.54 kB (-98.4%) —
Entries (21)
Entry Initial
. 1.18 kB
/dom 121 B
/dom/dash 3.28 kB
/dom/audio-host 1.10 kB
/dom/cloudflare 3.69 kB
/dom/custom-media-element 2.09 kB
/dom/dash 209.83 kB
/dom/google-cast 4.06 kB
/dom/hls-js 139.17 kB
/dom/media-host 1.20 kB
/dom/media-played-ranges 576 B
/dom/mux 162.77 kB
/dom/native-hls 5.25 kB
/dom/shaka 197.02 kB
/dom/spotify 3.58 kB
/dom/tiktok 3.57 kB
/dom/twitch 3.62 kB
/dom/video-host 1.39 kB
/dom/vimeo 10.62 kB
/dom/youtube 4.25 kB
/media-tracks 2.05 kB
📦 @videojs/spf — 3 small size changes
Path Base initial PR initial Initial diff Lazy diff
/moq 27.22 kB 27.27 kB +47 B (+0.2%) —
/moq-publish 21.53 kB 21.50 kB -28 B (-0.1%) —
/moq-publish-video 22.72 kB 22.65 kB -71 B (-0.3%) —
Entries (13)
Entry Initial
. 4.55 kB
/dom 6.61 kB
/hls 22.22 kB
/media-tracks 605 B
/moq 27.27 kB
/moq-publish 21.50 kB
/moq-publish-video 22.65 kB
/hls-background-video 15.91 kB
/hls-audio 19.96 kB
/hls-video 26.05 kB
/mux-audio 20.89 kB
/mux-background-video 15.86 kB
/mux-video 26.93 kB

ℹ️ How to interpret

Each entry is independently bundled, minified, and brotli-compressed. Initial size includes its static import graph; lazy dynamic chunks are reported separately.

Entries are not additive because their dependency graphs overlap. Preset rows represent realistic combined bundles.

Changes of 300 B or less across initial, lazy, and total size are collapsed, not discarded.

Run pnpm size locally to check current initial sizes.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 7 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name=".agents/plans/moq-transport-20-migration.md">

<violation number="1" location=".agents/plans/moq-transport-20-migration.md:21">
P2: Delete this temporary migration plan before merging instead of extending it with completed verification logs. Keeping it will leave non-authoritative, date-specific protocol guidance in the repository, which the plan-directory policy explicitly forbids.</violation>
</file>

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

@@ -9,7 +9,7 @@ code on `mmcc/moq` and `mmcc/moq-publisher` pinned draft-19
not change; loc.ts already uses the loc-04 property IDs that draft-20 §15.8

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2: Delete this temporary migration plan before merging instead of extending it with completed verification logs. Keeping it will leave non-authoritative, date-specific protocol guidance in the repository, which the plan-directory policy explicitly forbids.

Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At .agents/plans/moq-transport-20-migration.md, line 21:

<comment>Delete this temporary migration plan before merging instead of extending it with completed verification logs. Keeping it will leave non-authoritative, date-specific protocol guidance in the repository, which the plan-directory policy explicitly forbids.</comment>

<file context>
@@ -18,6 +18,29 @@ the spec text is ambiguous, and calls out each place it does.
 
 Temporary implementation notes — delete before merge per `AGENTS.md`.
 
+**Issue #45 verification (2026-09-16, moq-relay 0.14.17):** the shared codec
+uses bare Locations in both directions. Fixed-byte tests pin SUBSCRIBE_OK,
+REQUEST_OK, multi-byte IDs, following parameters/properties, and truncation.
</file context>

@mmcc
mmcc merged commit a5b4cb7 into mmcc/moq-publisher Sep 16, 2026
26 of 27 checks passed
@mmcc
mmcc deleted the fix/moq-relay-0.14.17-publisher branch September 16, 2026 17:09
mmcc added a commit that referenced this pull request Sep 18, 2026
Brings the publisher stack onto mmcc/moq at 2fefce4 (PRs #47, #50,
#51): subscriber location framing for moq-relay 0.14.17, isolated
subscription recovery attempts with preserved retry backoff, and the
moq publishing guide under packages/spf/docs.

No publisher-side ports were needed. The LARGEST_OBJECT bare-Location
codec change from PR #47 was already on this branch via PR #48, so
control-messages.ts and its tests merge to the existing content.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant