Skip to content

feat(spf): speak moq-transport draft-20 (moqt-20) - #41

Merged
mmcc merged 6 commits into
mmcc/moqfrom
feat/moq-transport-20
Sep 3, 2026
Merged

mmcc merged 6 commits into
mmcc/moqfrom
feat/moq-transport-20

Conversation

@mmcc

@mmcc mmcc commented Sep 3, 2026 •

Copy link
Copy Markdown
Owner

Summary

Cut the MoQ playback stack over from moq-transport draft-19 to draft-20 (moqt-20), the version moq-relay 0.14.14 now speaks across the fleet. Vendors the draft texts under internal/specs/moq/ so the codec can be reviewed against the spec offline, and records the migration plan and live interop findings under .agents/plans/.

Changes

  • ALPN moqt-20; PUBLISH_STATE_NOTIFY, FILL_PARAMETERS and INCLUDE_PROPERTIES decode instead of closing the session; End of Timed-Out Range is read on fetch streams; the codes draft-20 removed (SUBSCRIPTION_ENDED, INVALID_JOINING_REQUEST_ID, VERSION_NEGOTIATION_FAILED) are gone.
  • LOCATION_FILTER is draft-20's length-counted field list. The LocationFilter union is now none / next-object / relative-group / absolute; an open-ended absolute {0,0} normalizes to no filter per §5.1.2.
  • FETCH takes the SUBSCRIBE body with its range in LOCATION_FILTER; the Standalone / Joining structures are gone.
  • The catalog joins with a relative-group 1 subscription and no FETCH. Draft-20 relays no longer replay the current group for a Next Object subscription, and against moq-relay the joining FETCH never carried catalog data, so this is what keeps catalogs resolving. Deltas apply only against the independent object of their own group.
  • LARGEST_OBJECT and INCLUDE_PROPERTIES are framed length-prefixed to match moq-relay (feat(moq-net): add moq-transport draft-20 (moqt-20) moq-dev/moq#3255 records the disagreement with the spec text); the framing is byte-pinned against moq-dev's vector.
  • Two pre-existing bugs fixed along the way: REQUEST_UPDATE now consumes its own Request ID (§10.1), and PUBLISH_DONE's 2^64−1 "could not count" Stream Count sentinel decodes as undefined instead of failing the session.
  • Sandbox templates and comments move to draft-20 wording; the loopback relay emits the loc-04 timestamp id.
Implementation details
  • Hard cutover, no draft-19 fallback: the fleet (mux.global and relay.mux.dev) is uniformly on 0.14.14. MOQT_PROTOCOL_ID is the single offered protocol.
  • Video and switch handoffs keep their semantics under the new names (relative-group 0); audio's next-object join now starts at the live edge rather than the group start, which the latency controller absorbed in testing.
  • Fills are decoded but not requested; fill-stream routing is deferred (Phase 6 in the plan). An unsolicited fetch stream is dropped, not fatal.
  • The spf size script predates the Vite+ move and cannot run; measured with rolldown directly, the MoQ engine entry grows ~0.1 KB min+gzip.

Testing

  • pnpm -F @videojs/spf test — node projects 69 files / 1242 tests, browser projects 49 files / 765 tests (11 skipped); pnpm typecheck, pnpm lint, pnpm check:workspace pass.
  • Live against sjc.relay.mux.global (moq-relay 0.14.14) with a synthetic draft-19 publisher from the mmcc/moq-publisher sandbox: moqt-20 negotiated, catalog resolved from the relative-group 1 replay (object 0 delivered), a next-object catalog subscription confirmed strict (empty stream), video join delivered from the IDR at object 0 with LARGEST_OBJECT {35,28} decoding correctly, player stable at the 0.5 s latency target. Details in .agents/plans/moq-transport-20-migration.md.
  • relay.mux.dev could not be tested: its certificate expired 2026-08-26.

🤖 Generated with Claude Code


Summary by cubic

Cuts the MoQ playback stack from moq-transport draft-19 to draft-20 (moqt-20), the version moq-relay 0.14.14 speaks across the fleet, with no draft-19 fallback. Vendors the draft texts under internal/specs/moq/ for offline review and records the migration plan and live interop findings under .agents/plans/.

Protocol changes

  • ALPN moves to moqt-20; PUBLISH_STATE_NOTIFY, FILL_PARAMETERS, and INCLUDE_PROPERTIES decode instead of closing the session.
  • LOCATION_FILTER becomes draft-20's length-counted field list (none / next-object / relative-group / absolute); FETCH takes the SUBSCRIBE body with its range in LOCATION_FILTER.
  • Catalogs now resolve via a relative-group 1 subscription with no FETCH, since draft-20 relays no longer replay the current group for Next Object subscriptions.
  • LARGEST_OBJECT and INCLUDE_PROPERTIES are framed length-prefixed to match moq-relay.
  • Audio's next-object join starts at the live edge instead of the group start; fills decode but aren't requested, and unsolicited fetch streams are dropped, not fatal.
  • REQUEST_UPDATE consumes its own Request ID, and PUBLISH_DONE's Stream Count decodes as undefined only for the exact 2^64−1 sentinel — any other count past the 2^53−1 ceiling stays a protocol error.
  • A reordered independent catalog object from an older group is dropped rather than rolling the presentation back, and the catalog's base group advances only after its independent object parses.
  • Accepting an incoming PUBLISH sends a bare PUBLISH_OK; parameters on it would be a protocol violation.

Testing

  • Full test suite, typecheck, lint, and workspace checks pass.
  • Live interop against sjc.relay.mux.global (moq-relay 0.14.14) negotiated moqt-20, resolved the catalog from the relative-group 1 replay, and delivered video from the IDR; relay.mux.dev was skipped due to an expired certificate.

Written for commit c1f23df. Summary will update on new commits.

Review in cubic

mmcc added 4 commits September 2, 2026 23:43
Vendor draft-ietf-moq-transport-20, draft-ietf-moq-loc-04 and draft-ietf-moq-msf-01 under
internal/specs/moq with provenance, point AGENTS.md at them, and record the draft-19 to draft-20
migration plan grounded in moq-relay 0.14.14's implementation.
Cut the MoQ stack over from draft-19 to draft-20, matching moq-relay 0.14.14:

- ALPN moqt-20; decode PUBLISH_STATE_NOTIFY (0x22), FILL_PARAMETERS (0x23) and
  INCLUDE_PROPERTIES (0x35); read End of Timed-Out Range (0x20C); drop SUBSCRIPTION_ENDED,
  INVALID_JOINING_REQUEST_ID and VERSION_NEGOTIATION_FAILED.
- LOCATION_FILTER is the length-counted field list (none / relative-group / next-object /
  absolute); FETCH takes the SUBSCRIBE body with its range in LOCATION_FILTER.
- LARGEST_OBJECT and INCLUDE_PROPERTIES are framed length-prefixed, as moq-relay does
  (moq-dev/moq#3255 records the spec conflict).
- The catalog joins with a relative-group 1 subscription and no FETCH: draft-20 relays no longer
  replay the current group for Next Object, and the joining FETCH never carried catalog data.
- REQUEST_UPDATE consumes its own Request ID (section 10.1); PUBLISH_DONE's 2^64-1 Stream Count
  sentinel decodes as undefined instead of failing the session.
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 3, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-03T15:20:05.482918Z e412543 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

github-actions Bot commented Sep 3, 2026 •

Copy link
Copy Markdown

📦 Bundle Size Report

🎨 @videojs/html — 1 small size change
Path Base initial PR initial Initial diff Lazy diff
/media/simple-moq-video 28.43 kB 28.56 kB +132 B (+0.5%) —
Presets (7)
Entry Initial Lazy
/video (default) 61.27 kB 56.87 kB
/video (default + hls) 200.18 kB 56.87 kB
/video (minimal) 60.94 kB 56.87 kB
/video (minimal + hls) 199.90 kB 56.87 kB
/audio (default) 51.07 kB 56.87 kB
/audio (minimal) 47.13 kB 56.87 kB
/background 11.47 kB 56.87 kB
Media (20)
Entry Initial
/media/mux-video 142.33 kB
/media/mux-audio 142.05 kB
/media/background-video 1.16 kB
/media/cloudflare-video 6.25 kB
/media/dash-video 211.72 kB
/media/google-cast 6.52 kB
/media/hls-audio 22.21 kB
/media/hls-background-video 16.85 kB
/media/hls-video 28.13 kB
/media/hlsjs-video 141.03 kB
/media/mux-background-video 16.86 kB
/media/mux-data 26.70 kB
/media/native-hls-video 7.51 kB
/media/shaka-video 199.21 kB
/media/simple-moq-video 28.56 kB
/media/spotify-audio 6.24 kB
/media/tiktok-video 6.29 kB
/media/twitch-video 6.19 kB
/media/vimeo-video 13.03 kB
/media/youtube-video 6.79 kB
Players (5)
Entry Initial Lazy
/video/player 9.65 kB 56.87 kB
/audio/player 6.09 kB 56.87 kB
/background/player 4.45 kB 56.87 kB
/live-video/player 9.03 kB 56.87 kB
/live-audio/player 6.12 kB 56.87 kB
Skins (37)
Entry Type Initial Lazy
/video/minimal-skin.css css 6.50 kB —
/video/skin.css css 6.30 kB —
/video/minimal-skin js 59.45 kB 56.87 kB
/video/minimal-skin.tailwind js 59.71 kB 56.87 kB
/video/minimal-skin2 js 7.07 kB —
/video/skin js 59.64 kB 56.87 kB
/video/skin.tailwind js 60.01 kB 56.87 kB
/video/skin2 js 6.91 kB —
/audio/minimal-skin.css css 4.87 kB —
/audio/skin.css css 4.79 kB —
/audio/minimal-skin js 45.62 kB 56.87 kB
/audio/minimal-skin.tailwind js 45.91 kB 56.87 kB
/audio/minimal-skin2 js 5.27 kB —
/audio/skin js 49.48 kB 56.87 kB
/audio/skin.tailwind js 49.77 kB 56.87 kB
/audio/skin2 js 5.23 kB —
/background/skin.css css 145 B —
/background/skin js 9.72 kB 56.87 kB
/background/skin2 js 190 B —
/live-video/minimal-skin.css css 6.50 kB —
/live-video/skin.css css 6.30 kB —
/live-video/minimal-skin js 53.49 kB 56.87 kB
/live-video/minimal-skin.tailwind js 53.52 kB 56.87 kB
/live-video/minimal-skin2 js 7.07 kB —
/live-video/skin js 56.08 kB 56.87 kB
/live-video/skin.tailwind js 56.22 kB 56.87 kB
/live-video/skin2 js 6.91 kB —
/live-audio/minimal-skin.css css 4.87 kB —
/live-audio/skin.css css 4.79 kB —
/live-audio/minimal-skin js 38.92 kB 56.87 kB
/live-audio/minimal-skin.tailwind js 38.02 kB 56.87 kB
/live-audio/minimal-skin2 js 5.27 kB —
/live-audio/skin js 42.52 kB 56.87 kB
/live-audio/skin.tailwind js 41.69 kB 56.87 kB
/live-audio/skin2 js 5.23 kB —
/global.css css 190 B —
/shared.css css 118 B —
UI Components (49)
Entry Initial Lazy
/ui/airplay-button 11.15 kB 56.87 kB
/ui/alert-dialog 9.14 kB 56.87 kB
/ui/audio-track-radio-group 11.29 kB 56.87 kB
/ui/buffering-indicator 8.56 kB 56.87 kB
/ui/captions-button 11.40 kB 56.87 kB
/ui/captions-radio-group 11.36 kB 56.87 kB
/ui/cast-button 11.11 kB 56.87 kB
/ui/container 9.41 kB 56.87 kB
/ui/controls 8.77 kB 56.87 kB
/ui/controls-backdrop 1.69 kB 56.87 kB
/ui/controls-content 1.67 kB 56.87 kB
/ui/dialog 9.06 kB 56.87 kB
/ui/dialog-backdrop 1.70 kB 56.87 kB
/ui/dialog-close 2.01 kB 56.87 kB
/ui/dialog-description 1.69 kB 56.87 kB
/ui/dialog-popup 1.87 kB 56.87 kB
/ui/dialog-title 1.70 kB 56.87 kB
/ui/error-dialog 12.63 kB 56.87 kB
/ui/fullscreen-button 11.10 kB 56.87 kB
/ui/gesture 9.37 kB 56.87 kB
/ui/hotkey 9.80 kB 56.87 kB
/ui/menu 19.98 kB 56.87 kB
/ui/mute-button 11.14 kB 56.87 kB
/ui/pip-button 11.08 kB 56.87 kB
/ui/play-button 11.09 kB 56.87 kB
/ui/playback-rate-button 11.20 kB 56.87 kB
/ui/playback-rate-radio-group 11.27 kB 56.87 kB
/ui/popover 8.53 kB 56.87 kB
/ui/poster 8.63 kB 56.87 kB
/ui/quality-radio-group 11.87 kB 56.87 kB
/ui/seek-button 11.14 kB 56.87 kB
/ui/seek-indicator 12.47 kB 56.87 kB
/ui/seek-indicator-value 1.10 kB —
/ui/slider 12.01 kB 56.87 kB
/ui/status-announcer 10.56 kB 56.87 kB
/ui/status-indicator 12.82 kB 56.87 kB
/ui/status-indicator-value 1.10 kB —
/ui/thumbnail 9.73 kB 56.87 kB
/ui/time 10.81 kB 56.87 kB
/ui/time-slider 14.93 kB 56.87 kB
/ui/time-slider-chapter-title 8.74 kB 56.87 kB
/ui/time-slider-chapters 9.69 kB 56.87 kB
/ui/title 8.13 kB 56.87 kB
/ui/tooltip 9.92 kB 56.87 kB
/ui/volume-indicator 12.85 kB 56.87 kB
/ui/volume-indicator-fill 1.11 kB —
/ui/volume-indicator-value 1.10 kB —
/ui/volume-popover 14.67 kB 56.87 kB
/ui/volume-slider 12.66 kB 56.87 kB
⚛️ @videojs/react — no changes
Presets (7)
Entry Initial Lazy
/video (default) 47.76 kB 56.87 kB
/video (default + hls) 185.56 kB 56.87 kB
/video (minimal) 47.80 kB 56.87 kB
/video (minimal + hls) 185.51 kB 56.87 kB
/audio (default) 37.12 kB 56.87 kB
/audio (minimal) 37.18 kB 56.87 kB
/background 581 B 56.87 kB
Media (23)
Entry Initial
/media/mux-video/hls-js 140.62 kB
/media/mux-video/spf 27.54 kB
/media/mux-audio/hls-js 140.46 kB
/media/mux-audio/spf 21.44 kB
/media/background-video 402 B
/media/cloudflare-video 4.35 kB
/media/dash-video 210.29 kB
/media/google-cast 5.34 kB
/media/hls-audio 20.48 kB
/media/hls-background-video 16.40 kB
/media/hls-video 26.56 kB
/media/hlsjs-video 139.58 kB
/media/mux-audio 140.44 kB
/media/mux-background-video 16.47 kB
/media/mux-data 25.49 kB
/media/mux-video 140.54 kB
/media/native-hls-video 5.76 kB
/media/shaka-video 197.52 kB
/media/spotify-audio 4.22 kB
/media/tiktok-video 4.18 kB
/media/twitch-video 4.30 kB
/media/vimeo-video 11.21 kB
/media/youtube-video 4.86 kB
Players (5)
Entry Initial Lazy
/video/player 7.51 kB 56.87 kB
/audio/player 3.95 kB 56.87 kB
/background/player 2.27 kB 56.87 kB
/live-video/player 6.91 kB 56.87 kB
/live-audio/player 3.95 kB 56.87 kB
Skins (26)
Entry Type Initial Lazy
/video/minimal-skin.css css 6.40 kB —
/video/skin.css css 6.20 kB —
/video/minimal-skin js 47.67 kB 56.87 kB
/video/minimal-skin.tailwind js 54.62 kB 56.87 kB
/video/skin js 47.67 kB 56.87 kB
/video/skin.tailwind js 54.40 kB 56.87 kB
/audio/minimal-skin.css css 4.73 kB —
/audio/skin.css css 4.65 kB —
/audio/minimal-skin js 37.11 kB 56.87 kB
/audio/minimal-skin.tailwind js 42.21 kB 56.87 kB
/audio/skin js 36.99 kB 56.87 kB
/audio/skin.tailwind js 42.17 kB 56.87 kB
/background/skin.css css 90 B —
/background/skin js 277 B —
/live-video/minimal-skin.css css 6.40 kB —
/live-video/skin.css css 6.20 kB —
/live-video/minimal-skin js 39.77 kB 56.87 kB
/live-video/minimal-skin.tailwind js 46.43 kB 56.87 kB
/live-video/skin js 39.79 kB 56.87 kB
/live-video/skin.tailwind js 46.43 kB 56.87 kB
/live-audio/minimal-skin.css css 4.73 kB —
/live-audio/skin.css css 4.65 kB —
/live-audio/minimal-skin js 28.82 kB 56.87 kB
/live-audio/minimal-skin.tailwind js 32.77 kB 56.87 kB
/live-audio/skin js 28.88 kB 56.87 kB
/live-audio/skin.tailwind js 32.93 kB 56.87 kB
UI Components (39)
Entry Initial Lazy
/ui/airplay-button 10.28 kB 56.87 kB
/ui/alert-dialog 4.41 kB 56.87 kB
/ui/audio-track 7.89 kB 56.87 kB
/ui/audio-track-radio-group 9.05 kB 56.87 kB
/ui/buffering-indicator 7.72 kB 56.87 kB
/ui/captions-button 10.25 kB 56.87 kB
/ui/captions-radio-group 9.17 kB 56.87 kB
/ui/cast-button 10.26 kB 56.87 kB
/ui/controls 7.51 kB 56.87 kB
/ui/dialog 4.44 kB 56.87 kB
/ui/error-dialog 11.44 kB 56.87 kB
/ui/fullscreen-button 10.24 kB 56.87 kB
/ui/gesture 7.80 kB 56.87 kB
/ui/hotkey 8.21 kB 56.87 kB
/ui/live-button 8.69 kB 56.87 kB
/ui/menu 18.91 kB 56.87 kB
/ui/mute-button 10.26 kB 56.87 kB
/ui/pip-button 10.23 kB 56.87 kB
/ui/play-button 10.21 kB 56.87 kB
/ui/playback-rate 7.94 kB 56.87 kB
/ui/playback-rate-button 10.22 kB 56.87 kB
/ui/playback-rate-radio-group 9.09 kB 56.87 kB
/ui/popover 8.12 kB 56.87 kB
/ui/poster 7.49 kB 56.87 kB
/ui/quality 8.38 kB 56.87 kB
/ui/quality-radio-group 9.54 kB 56.87 kB
/ui/seek-button 10.25 kB 56.87 kB
/ui/seek-indicator 11.75 kB 56.87 kB
/ui/slider 12.60 kB 56.87 kB
/ui/status-announcer 10.01 kB 56.87 kB
/ui/status-indicator 12.07 kB 56.87 kB
/ui/thumbnail 8.64 kB 56.87 kB
/ui/time 9.69 kB 56.87 kB
/ui/time-slider 14.07 kB 56.87 kB
/ui/title 7.19 kB 56.87 kB
/ui/tooltip 8.90 kB 56.87 kB
/ui/volume-indicator 12.15 kB 56.87 kB
/ui/volume-popover 14.13 kB 56.87 kB
/ui/volume-slider 12.03 kB 56.87 kB
🧩 @videojs/core — no changes
Entries (76)
Entry Initial Lazy
. 13.02 kB —
/dom 21.92 kB 56.87 kB
/vjsc 1.74 kB —
/i18n 3.23 kB 56.87 kB
/i18n/locales/all 34.97 kB —
/i18n/locales/ar 1.22 kB —
/i18n/locales/az 1.09 kB —
/i18n/locales/bg 1.29 kB —
/i18n/locales/bn 1.23 kB —
/i18n/locales/bs 1.00 kB —
/i18n/locales/ca 1.07 kB —
/i18n/locales/cs 1.07 kB —
/i18n/locales/cy 1.02 kB —
/i18n/locales/da 1006 B —
/i18n/locales/de 1.09 kB —
/i18n/locales/el 1.49 kB —
/i18n/locales/en 785 B —
/i18n/locales/es 1018 B —
/i18n/locales/et 1.05 kB —
/i18n/locales/eu 1.03 kB —
/i18n/locales/fa 1.22 kB —
/i18n/locales/fi 1.04 kB —
/i18n/locales/fr 1.07 kB —
/i18n/locales/gd 1.10 kB —
/i18n/locales/gl 1022 B —
/i18n/locales/he 1.14 kB —
/i18n/locales/hi 1.30 kB —
/i18n/locales/hr 1.02 kB —
/i18n/locales/hu 1.10 kB —
/i18n/locales/id 919 B —
/i18n/locales/it 1.01 kB —
/i18n/locales/ja 1.18 kB —
/i18n/locales/ko 1.14 kB —
/i18n/locales/lt 1.02 kB —
/i18n/locales/lv 1.09 kB —
/i18n/locales/mr 1.30 kB —
/i18n/locales/nb 987 B —
/i18n/locales/ne 1.29 kB —
/i18n/locales/nl 1.00 kB —
/i18n/locales/nn 987 B —
/i18n/locales/oc 1.08 kB —
/i18n/locales/pl 1.14 kB —
/i18n/locales/pt 1.03 kB —
/i18n/locales/pt-BR 1.03 kB —
/i18n/locales/pt-PT 1.01 kB —
/i18n/locales/ro 1.07 kB —
/i18n/locales/ru 1.40 kB —
/i18n/locales/sk 1.10 kB —
/i18n/locales/sl 1.04 kB —
/i18n/locales/sr 1.07 kB —
/i18n/locales/sv 1.01 kB —
/i18n/locales/te 1.32 kB —
/i18n/locales/th 1.29 kB —
/i18n/locales/tr 1.08 kB —
/i18n/locales/uk 1.41 kB —
/i18n/locales/vi 1.11 kB —
/i18n/locales/zh 1.02 kB —
/i18n/locales/zh-CN 1.02 kB —
/i18n/locales/zh-TW 1.02 kB —
/i18n/text/airplay 101 B —
/i18n/text/buttons 137 B —
/i18n/text/captions 93 B —
/i18n/text/cast 114 B —
/i18n/text/common 90 B —
/i18n/text/container 75 B —
/i18n/text/errors 285 B —
/i18n/text/fullscreen 98 B —
/i18n/text/live 126 B —
/i18n/text/menu 249 B —
/i18n/text/pip 101 B —
/i18n/text/playback 80 B —
/i18n/text/seek 105 B —
/i18n/text/slider 65 B —
/i18n/text/status 222 B —
/i18n/text/time 280 B —
/i18n/text/volume 133 B —
🏷️ @videojs/element — no changes
Entries (2)
Entry Initial
. 1.05 kB
/context 943 B
📦 @videojs/store — no changes
Entries (3)
Entry Initial
. 1.72 kB
/html 703 B
/react 365 B
🔧 @videojs/utils — no changes
Entries (13)
Entry Initial
/array 271 B
/dom 5.02 kB
/events 320 B
/function 386 B
/i18n 249 B
/jwt 176 B
/object 535 B
/predicate 297 B
/percent 281 B
/string 239 B
/style 212 B
/time 976 B
/number 199 B

📦 @videojs/media

Path Base initial PR initial Initial diff Lazy diff
/dom/dash 209.83 kB 3.28 kB -206.54 kB (-98.4%) —
Entries (21)
Entry Initial
. 1.07 kB
/dom 121 B
/dom/dash 3.28 kB
/dom/audio-host 1.10 kB
/dom/cloudflare 3.69 kB
/dom/custom-media-element 2.09 kB
/dom/dash 209.83 kB
/dom/google-cast 4.06 kB
/dom/hls-js 139.17 kB
/dom/media-host 1.20 kB
/dom/media-played-ranges 576 B
/dom/mux 162.77 kB
/dom/native-hls 5.25 kB
/dom/shaka 197.02 kB
/dom/spotify 3.58 kB
/dom/tiktok 3.57 kB
/dom/twitch 3.62 kB
/dom/video-host 1.39 kB
/dom/vimeo 10.62 kB
/dom/youtube 4.25 kB
/media-tracks 2.05 kB
📦 @videojs/spf — 1 small size change
Path Base initial PR initial Initial diff Lazy diff
/moq 26.97 kB 27.10 kB +141 B (+0.5%) —
Entries (11)
Entry Initial
. 4.55 kB
/dom 6.61 kB
/hls 22.23 kB
/media-tracks 605 B
/moq 27.10 kB
/hls-background-video 15.87 kB
/hls-audio 20.01 kB
/hls-video 26.05 kB
/mux-audio 20.97 kB
/mux-background-video 15.90 kB
/mux-video 26.96 kB

ℹ️ How to interpret

Each entry is independently bundled, minified, and brotli-compressed. Initial size includes its static import graph; lazy dynamic chunks are reported separately.

Entries are not additive because their dependency graphs overlap. Preset rows represent realistic combined bundles.

Changes of 300 B or less across initial, lazy, and total size are collapsed, not discarded.

Run pnpm size locally to check current initial sizes.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e41254377d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +5 to +6
(its Appendix A.1 is the authoritative change list). The code on `mmcc/moq`
and `mmcc/moq-publisher` pins draft-19 (`MOQT_PROTOCOL_ID = 'moqt-19'`).

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Remove the completed temporary migration plan

This completed migration checks in a 428-line temporary plan that still states the code pins moqt-19, although this commit switches it to moqt-20. Once merged, that stale implementation artifact will mislead future retrieval-led work; remove it and also delete the new reference from moq-engine-implementation.md, as repository guidance explicitly requires temporary .agents/plans/ notes to be deleted before merge.

AGENTS.md reference: AGENTS.md:L64-L70

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keeping the plan on this branch deliberately: the PR targets the long-lived mmcc/moq feature branch, which already carries .agents/plans/moq-engine-implementation.md under the same rule, and both get deleted when mmcc/moq merges to main. The stale sentence that said the code still pins moqt-19 is corrected in c1f23df.

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 34 files

Not reviewed (too large): internal/specs/moq/draft-ietf-moq-transport-20.txt (~8,848 lines), internal/specs/moq/draft-ietf-moq-msf-01.txt (~4,144 lines) - if these are generated or fixture files, add them to ignored paths to exclude them from future reviews.

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name=".agents/plans/moq-transport-20-migration.md">

<violation number="1" location=".agents/plans/moq-transport-20-migration.md:17">
P3: This `.agents/plans/` file is committed into the PR even though AGENTS.md (and the file's own header) require temporary plans to be deleted before merge. It also mixes an implementation plan with a completed-work log and live interop results, which README.md says do not belong in the repository. Remove this file from the PR; move durable rationale into `internal/decisions/` or `internal/design/` only if explicitly requested.</violation>
</file>

Tip: cubic can generate docs of your entire codebase and keep them up to date. Try it here.

Re-trigger cubic

@@ -0,0 +1,428 @@
# MoQ transport draft-20 migration plan

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P3: This .agents/plans/ file is committed into the PR even though AGENTS.md (and the file's own header) require temporary plans to be deleted before merge. It also mixes an implementation plan with a completed-work log and live interop results, which README.md says do not belong in the repository. Remove this file from the PR; move durable rationale into internal/decisions/ or internal/design/ only if explicitly requested.

Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At .agents/plans/moq-transport-20-migration.md, line 17:

<comment>This `.agents/plans/` file is committed into the PR even though AGENTS.md (and the file's own header) require temporary plans to be deleted before merge. It also mixes an implementation plan with a completed-work log and live interop results, which README.md says do not belong in the repository. Remove this file from the PR; move durable rationale into `internal/decisions/` or `internal/design/` only if explicitly requested.</comment>

<file context>
@@ -0,0 +1,428 @@
+only draft-20 peer we talk to, so this plan follows its wire behavior where
+the spec text is ambiguous, and calls out each place it does.
+
+Temporary implementation notes — delete before merge per `AGENTS.md`.
+
+## What changed on the wire (draft-19 → draft-20)
</file context>

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keeping the plan on this branch deliberately: the PR targets the long-lived mmcc/moq feature branch, which already carries .agents/plans/moq-engine-implementation.md under the same rule, and both get deleted when mmcc/moq merges to main. The stale sentence that said the code still pins moqt-19 is corrected in c1f23df.

mmcc added 2 commits September 3, 2026 15:40
- resolve-catalog: an independent catalog object from a group older than the current base is
  a reordered straggler; drop it instead of rolling the presentation back.
- session: accepting an incoming PUBLISH sends a bare PUBLISH_OK. Draft-20 allows subscription
  parameters only on PUBLISH and REQUEST_UPDATE, and a parameter in the wrong message is a
  PROTOCOL_VIOLATION (section 10.2.1).
- resolve-catalog: move the base group only after its independent object parsed, so a malformed
  catalog cannot route the next group's deltas onto the previous catalog.
- PUBLISH_DONE Stream Count: only the exact 2^64-1 sentinel reads as unknown; any other count past
  2^53-1 stays a protocol error.
- moq-session: name the relay fleet the same way in all three comments.
- plan: the draft-19 pin is described as the state before this branch.
@mmcc
mmcc merged commit ef10353 into mmcc/moq Sep 3, 2026
25 of 26 checks passed
@mmcc
mmcc deleted the feat/moq-transport-20 branch September 3, 2026 16:07
mmcc added a commit that referenced this pull request Sep 4, 2026
Brings the publisher stack onto the moq-transport draft-20 (moqt-20)
cutover that landed on mmcc/moq in PR #41.

Publisher-side ports beyond the textual conflict (the TRACK_PROPERTY block
in control-messages.ts):
- publish-session: inbound REQUEST_UPDATE consumes its own Request ID
  (§10.1) — claimed like every other request id, so a reuse is
  session-fatal; onRequestUpdate reports the updated request's id and
  the update's own id.
- relay-hub test helper: resolves draft-20 Location Filters the way
  moq-relay 0.14.14 does (relative-group 1 replays the current group,
  relative-group 0 waits for the next, next-object is strict), pulls
  upstream with relative-group 1, and sends LARGEST_OBJECT in
  SUBSCRIBE_OK once a track has content.
- raw-peer helper and the byte-pinned SUBSCRIBE vector: the relay's
  upstream join is now the single field 0x1 (relative-group 1).
- moq-publisher sandbox loopback relay: pulls upstream with the same
  relative-group 1 filter; draft-20 prose.
- Tests: REQUEST_UPDATEs use fresh request ids; new coverage for a
  reused id closing the session.
- Prose: draft-19 references in publisher code, tests, and the sandbox
  template updated; Phase 5 status recorded in the migration plan.

Still owed on this branch (Phase 5 of the plan): serving relative-group 1
from the in-progress group's object 0 in track-publisher, LARGEST_OBJECT
in the publisher's SUBSCRIBE_OK, and open-and-reset for inbound
FILL_PARAMETERS.
mmcc added a commit that referenced this pull request Sep 4, 2026
Finishes the publisher side of the moq-transport draft-20 migration begun
on mmcc/moq (PR #41). Three behaviors the relay's draft-20 upstream join
needs:

- In-progress-group replay. `track-publisher.ts` retains the current
  group (keyframe + deltas, bound or not, reset each keyframe) and, on
  bind, replays it from object 0 under the new alias before continuing
  live. A subscription joining mid-group — the relay's `relative-group 1`
  upstream join — now decodes instantly instead of waiting a GOP, and no
  subgroup stream begins partway through a group (the peer drops those).
  Group-per-frame tracks keep using `replayLastGroupOnBind`.

- LARGEST_OBJECT in SUBSCRIBE_OK. The actor tracks the largest
  (group, object) it has written on its snapshot; `setup-track-publishers`
  passes a `getLargestObject` reader into `registerTrack`, and the session
  reports LARGEST_OBJECT (§10.2.17) in SUBSCRIBE_OK once content exists,
  omitting it before. Pulled at subscribe time, so no snapshot churn. The
  sandbox loopback relay's SUBSCRIBE_OK parser now skips the parameter
  block by parity instead of asserting it is empty.

- Inbound FILL_PARAMETERS. `#openAndResetFill` opens a uni stream, writes
  a FETCH_HEADER carrying the initiating Request ID, and resets it — the
  §5.1.3.1 minimum for an origin that serves no fills (reset = failure; a
  FIN would falsely claim an empty range). Wired on the inbound SUBSCRIBE
  and REQUEST_UPDATE paths, gated on Forward State 1, with FILL_PARAMETERS
  pulled out of the update's unsupported-parameter set. `encodeFetchHeader`
  added to `object-stream.ts`.

Tests: rewrote the four track-publisher/behavior tests whose documented
"join at next keyframe" behavior the replay supersedes; added actor
coverage for Largest Object tracking and session coverage for
LARGEST_OBJECT in SUBSCRIBE_OK and the fill open-and-reset. All spf test
projects pass (node 353, browser 130); typecheck, lint, and format clean.
Not yet verified live against the relay fleet.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant