Repository navigation
fix(skin): migrate publisher skin to the stabilized css token vocabulary - #38
Merged
Merged
Conversation
The css cleanup in videojs#2094 renamed the default skin's internal tokens from --media-* to unprefixed names (--surface-*, --popup-transition-*, --default-accent-color, --focus-ring-color, ...), reserving --media-* for user-facing overrides read through var() fallbacks. The publisher skin still defined the old names, so menu/button hover highlights, the glass surface fill, popup transitions, and the focus ring all resolved to nothing. Also repoints two dangling references (--media-current-shadow-color, --media-color-primary) and stops defining the public --media-capture-placeholder-background knob on the container, which was blocking host-level overrides.
📦 Bundle Size Report🎨 @videojs/html — 3 small size changes
Presets (7)
Media (17)
Players (6)
Skins (32)
UI Components (52)
⚛️ @videojs/react — 2 small size changes
Presets (7)
Media (19)
Players (5)
Skins (29)
UI Components (47)
🧩 @videojs/core — no changesEntries (77)
🏷️ @videojs/element — no changesEntries (2)
📦 @videojs/store — no changesEntries (3)
🔧 @videojs/utils — no changesEntries (13)
📦 @videojs/jsx — no changesEntries (3)
📦 @videojs/media — no changesEntries (15)
📦 @videojs/spf — no changesEntries (13)
ℹ️ How to interpretEach entry is independently bundled, minified, and brotli-compressed. Initial size includes its static import graph; lazy dynamic chunks are reported separately. Entries are not additive because their dependency graphs overlap. Preset rows represent realistic combined bundles. Changes of 300 B or less across initial, lazy, and total size are collapsed, not discarded. Run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The css cleanup in videojs#2094 (merged in via the last
mmcc/moqsync) renamed the default skin's internal tokens from--media-*to unprefixed names, reserving--media-*for user-facing overrides read throughvar()fallbacks. The publisher skin still defined the old vocabulary, so every style derived from those tokens silently resolved to nothing.Changes
--accent-background-colornow derives from a defined--default-accent-color)--surface-*)--popup-transition-*), and the focus ring uses--focus-ring-colorinstead of falling back tocurrentColor--publish-live-color,--quality-*-color,--publish-status-background); dangling--media-current-shadow-color/--media-color-primaryreferences repointed--media-capture-placeholder-backgroundis no longer defined on the container — it is a public override knob consumed via fallback, and the root definition was blocking host-level overridesTesting
pnpm -F @videojs/skins test(39 passed, includes canonical import check and type pass)turbo run build --filter=@videojs/html --filter=@videojs/react— bundled publisherskin.csscontains only new-vocabulary tokensoklch(1 0 0 / 0.1)highlight, subtle button hover resolves the same accent background🤖 Generated with Claude Code
Summary by cubic
Restores publisher skin visuals by migrating from deprecated
--media-*internal tokens to the stabilized unprefixed vocabulary. Previously, hover highlights, glass surfaces, popup transitions, and the focus ring resolved to nothing; now they render as intended.--surface-*,--popup-transition-*,--controls-transition-*,--error-dialog-transition-*,--default-accent-color, and--focus-ring-color. Publisher-only tokens now use--publish-live-color,--quality-*-color, and--publish-status-background.--media-current-shadow-colorto--shadow-current-colorand removes reliance on--media-color-primarywhere used.--media-capture-placeholder-backgroundon the container so host-level overrides take effect.@videojs/skinstests pass and bundles contain only the new vocabulary.Migration
--media-publish-live-color→--publish-live-color,--media-quality-{good,fair,poor}-color→--quality-{good,fair,poor}-color,--media-publish-status-background→--publish-status-background. No change needed for host-level--media-capture-placeholder-backgroundoverrides.Written for commit a05593f. Summary will update on new commits.