Repository navigation
Tests: keep setup_logging out of ~/Library/Logs; drop unused set_address - #20
Merged
Merged
Conversation
Protocol (sources cited in code and README): - Byte 4 of the input report: Capture is 0x02 and C is 0x10, not the reverse. Agreed by ndeadly/switch2_controller_research (hid_reports.md), esp-cpp/espp PR #765 (switch2_pro_report.hpp) and the hardware capture in issue #14. Also fixes Capture -> DSU Touch. - Read the factory stick calibration over the command channel (649d4ac9-...f005 / replies c765a961-...) and light player LED 1. Frame format, SPI addresses 0x130A8/0x130E8 and block layout adapted from kennethreitz/switch2bridge-macos@975f329 (issue #14, MIT), based on darthcloud/BlueRetro#1249; addresses match SDL's Switch 2 driver. Best effort: a silent controller keeps the nominal 2048 range. - README: 7492866c-...c0f8 is notify-only, document the command channel. Hardening: - mappings.json written atomically (temp file + os.replace) - "dsu.enabled" must be a boolean (bool("false") was True) - warn when the DSU server is bound to a non-loopback address - DSU socket: drop SO_REUSEADDR (useless for UDP; on Linux it let a second server silently share the port) - worker -> UI messages taken atomically; stick hysteresis read under lock - asyncio.get_running_loop(); logging set up at startup, not import Build: Python 3.10+ (bleak 3 requires it), major-version upper bounds, py2app moved to requirements-build.txt, CI matrix 3.10/3.12/3.13, DMG README explains the macOS 15+ Gatekeeper "Open Anyway" flow. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SGsFjHBorX2mfsanZhFyzs
Actions → Release → Run workflow (tag input): checks the tag matches
APP_VERSION and doesn't exist yet, runs the tests, builds the DMG, then
creates the tag and the GitHub release with the DMG attached, using
.github/release-notes/<tag>.md as the body with {{SHA256}} replaced by
the DMG checksum.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SGsFjHBorX2mfsanZhFyzs
Follow-up to #17: - the setup_logging tests now point LOG_DIR at a temp dir and detach their handler afterwards, instead of creating controller2.log in the real ~/Library/Logs/Switch2Bridge and leaving a handler on bridge.log - Mappings.set_address() had no caller outside its own test Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SGsFjHBorX2mfsanZhFyzs
mlstr0m
pushed a commit
that referenced
this pull request
Sep 28, 2026
mlstr0m
pushed a commit
that referenced
this pull request
Sep 28, 2026
Covers #17 (--config, ble.address, per-config logs), #20, #21 (lint in CI) and #22 (…f8 known input characteristic). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SGsFjHBorX2mfsanZhFyzs
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the follow-up announced in #17.
setup_loggingtests createdcontroller2.login the real~/Library/Logs/Switch2Bridge/and left a handler attached to the realbridge.log. They now pointLOG_DIRat a temp dir, check that only the expected log files land there, and detach the handler afterwards.Mappings.set_address()had no caller outside its own test. Both are removed;ble.addressis still parsed from the config and covered by the existing tests.Tests: all 143 bridge checks and 52 DSU checks pass, and nothing is written under
~/Library/Logsanymore.🤖 Generated with Claude Code
https://claude.ai/code/session_01SGsFjHBorX2mfsanZhFyzs
Generated by Claude Code