Skip to content

[BUILD] Stamp org.opencontainers.image.revision label on UI image#3708

Merged
pini-sh-panda merged 1 commit into
developmentfrom
feat/image-revision-label
Jun 25, 2026
Merged

[BUILD] Stamp org.opencontainers.image.revision label on UI image#3708
pini-sh-panda merged 1 commit into
developmentfrom
feat/image-revision-label

Conversation

@bar-shem-tov

@bar-shem-tov bar-shem-tov commented Jun 24, 2026

Copy link
Copy Markdown
Collaborator

📝 Description

Adds the standard OCI revision label (org.opencontainers.image.revision) to the production UI image so the full UI commit SHA travels with the published image. This lets the MLRun release-promotion workflow derive the UI commit to tag straight from the image, instead of requiring an operator to paste it by hand.


🛠️ Changes Made

  • Dockerfile: declare ARG GIT_COMMIT_SHA and set LABEL org.opencontainers.image.revision=$GIT_COMMIT_SHA on the production stage.
  • package.json: pass --build-arg GIT_COMMIT_SHA="$(git rev-parse HEAD)" (the full SHA) from the docker build script.

✅ Checklist

  • I have given the PR a well-structured title describing the domain and the specific change that was made
  • I tested the changes in the browser (locally or via preview build)
  • I confirmed that existing tests pass
  • I added or updated unit / integration tests (if needed)
  • I checked that this change doesn’t introduce new console warnings or lint / formatting errors
  • I updated the relevant Jira ticket with the appropriate details and status

🔗 References


🚨 Potentially Breaking Changes

  • Yes
  • No

Metadata only — no behavior change to the running image. Images built before this change have no label; the consumer handles that by failing loud and asking for an explicit ui_commit_sha.


Includes DRC change

  • Yes
  • No

🔍 Additional Notes

  • Companion to the MLRun release-promotion generalization; that workflow consumes this label.

📸 Screenshots / Demos

N/A — no UI change.

Add a GIT_COMMIT_SHA build-arg (full git sha) and set it as the
org.opencontainers.image.revision OCI label on the production image so the
release promotion workflow can recover the UI commit via skopeo inspect.
The existing short-hash COMMIT_HASH file is left unchanged.
@bar-shem-tov bar-shem-tov marked this pull request as ready for review June 25, 2026 08:32
@pini-sh-panda pini-sh-panda merged commit f0a8d89 into development Jun 25, 2026
7 checks passed
@bar-shem-tov bar-shem-tov deleted the feat/image-revision-label branch June 25, 2026 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants