Tighten is_batched_event sub-event check#644
Merged
Merged
Conversation
davesh0812
approved these changes
Jun 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
is_batched_eventpreviously classified any event whose body contained items with a.bodyattribute as batched. This caught non-event objects like mlrun'sResponse, which also exposes.body."event"in the class name (lowercased), preserving duck-typing for non-storey event-like objects while excludingResponse-shaped payloads.Eventsub-events) and the negative case (Response-shaped sub-events).Test plan
tests/test_flow.py::test_is_batched_event_with_event_sub_eventstests/test_flow.py::test_is_batched_event_excludes_non_event_body_objectsPart of ML-12706 effort.