Skip to content

Param set sugar, take 2 - #194

Open
mb706 wants to merge 5 commits into
mainfrom
paramSetSugar
Open

Param set sugar, take 2#194
mb706 wants to merge 5 commits into
mainfrom
paramSetSugar

Conversation

@mb706

@mb706 mb706 commented Dec 11, 2017

Copy link
Copy Markdown
Collaborator

Alternative API for creating ParamSet objects, using nonstandard evaluation to enable short and concise input.

> pSS(a: logical, b: integer[0, 10], c: numeric^2)
           Type len Def      Constr Req Tunable Trafo
a       logical   -   -           -   -    TRUE     -
b       integer   -   -     0 to 10   -    TRUE     -
c numericvector   2   - -Inf to Inf   -    TRUE     -

@mb706

mb706 commented Dec 11, 2017

Copy link
Copy Markdown
Collaborator Author

Pretty much all the magic happens in R/ParamSetSugar.R.

@coveralls

coveralls commented Dec 11, 2017

Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.1%) to 96.186% when pulling 7e3e209 on paramSetSugar into 59c649e on master.

@jakob-r

jakob-r commented Dec 12, 2017

Copy link
Copy Markdown
Member

It looks nice. What are your thoughts on putting it in a little extra package. ParamHelperHelper? 😅
Just in case we can not decide whether we want a new meta language to be part of PH.

@berndbischl

Copy link
Copy Markdown
Member

it really shouldnt go into yet another package. but we might put it into PH2? that seems pretty advanced and we can then push a bigger change through?

@mb706

mb706 commented Dec 13, 2017

Copy link
Copy Markdown
Collaborator Author

What is the ETA of that? Does PH2 break much compatibility with the current "ParamHelpers"? I rely on Param Set Sugar in mlrCPO, but medium term I can also just ship it in mlrCPO if you think it doesn't belong here.

@jakob-r jakob-r added this to the v1.12 milestone Jun 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants