chore(skills): remove spent ai/skills migration vestiges (CHORE-003)#288
Merged
Conversation
SDD-008 migrated every skill to the vault SSOT (00_meta/skills) behind compile-harness; these leftovers were never cleaned up: - scripts/skills/migrate-to-vault.sh + tests/migrate-to-vault.bats: consumed one-shot repatriation script (17 skills migrated) and its test. - ai/skills/: lone README stub removed; its signpost value (skills SSOT = vault, deployed by compile-harness, do not add skills here) folded into README.md (AI Tools) and the architecture map. - docs/adr/dotfiles-architecture-map.md: fixed stale refs to the removed ai/skills tree and skills-to-opencode.sh (now compile-harness.sh). No behaviour change; setup deploys skills via compile-harness. The compile-harness.bats guard asserting setup no longer reads ai/skills stays in place.
mlorentedev
added
the
skip-sdd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the spent vestiges of the SDD-008 skill migration. SDD-008 moved every skill to the vault SSOT (
00_meta/skills) behind thecompile-harnesspipeline; these leftovers were never cleaned up.Changes
scripts/skills/migrate-to-vault.sh+tests/migrate-to-vault.bats— the one-shot repatriation script (consumed: 17 skills migrated) and its test.ai/skills/— it had been reduced to a lone README stub. Its signpost value (skills SSOT = vault, deployed bycompile-harness, "don't add skills here") is folded intoREADME.md(### AI Tools) and the architecture map, so the empty dir + stub is gone entirely.docs/adr/dotfiles-architecture-map.md— stale references to the removedai/skillstree andskills-to-opencode.shnow point tocompile-harness.sh.Verification
bats tests/*.bats: 1063 pass. The 3 failures inshell-profile.batsare pre-existing and environmental (that test executes live shell profiling, which the sandbox cannot run; it is untouched by this PR —git diff origin/main -- scripts/shell-profile.shis empty).compile-harness.batsguard asserting setup no longer readsai/skillsstays in place.compile-harness.SDD skip rationale
Mechanical vestige cleanup: deletes a consumed one-shot script + its test and a README stub, plus doc corrections. No public contract, no new dependency, no behaviour change. The diff exceeds 50 LOC only because of deletions (171 lines removed).