Update RFC 0004: address review feedback and add enhancements#18
Merged
Conversation
Contributor
Author
|
This mainly contains minor adjustments to address feedback from:
This uses the latest version of the server.json schema and follows its use of This also simplifies fetching of access bindings for a given alias or server version: Before (filter_string only): bindings = mlflow.genai.search_mcp_access_bindings(
server_name="io.github.anthropic/brave-search",
filter_string="server_alias = 'production'"
)After (direct params): bindings = mlflow.genai.search_mcp_access_bindings(
server_name="io.github.anthropic/brave-search",
server_alias="production",
) |
mprahl
approved these changes
May 14, 2026
TomeHirata
reviewed
May 19, 2026
| | `display_name` | `String(256)` | mutable human-readable label | | ||
| | `status` | `String(20)` | default `'draft'` | | ||
| | `tools` | `JSON` | nullable; mutable tool metadata (names, descriptions, input schemas) | | ||
| | `transport_types` | `JSON` | nullable; read-only; extracted from server_json at creation (e.g., `["stdio", "streamable-http"]`) | |
Collaborator
There was a problem hiding this comment.
if this is included in server_json, why do we need this separate field?
Contributor
Author
There was a problem hiding this comment.
Good point - I was thinking it would be a convenience, but maybe it is easy enough to go into the server_json.
I've removed this
Changes from reviewer feedback (TomeHirata, mprahl, thkim-us): - Add server_version and server_alias as direct params on search_mcp_access_bindings for common binding lookups - Add description fallback from server_json (API resolves like status) - Change icon to icons on MCPServer (list of sized variants matching upstream server.json icon schema) - Add environment variables display paragraph to UI section - Add transport_type filter for access binding search - Update server.json schema reference from 2025-09-29 to 2025-12-11 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Jon Burdo <jon@jonburdo.com>
jonburdo
force-pushed
the
mcp-registry-updates-1
branch
from
dcc56dc to
cda0388
Compare
Collaborator
|
Since the only comment from @TomeHirata was addressed, I'll go ahead and merge this. Feel free to post any additional feedback that comes up here or in Slack! |
31 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes from reviewer feedback (TomeHirata, mprahl, thkim-us):