Skip to content

Remove special tokens and count characters in ifeval - #46

Open
farook-edev wants to merge 1 commit into
mlcommons:mainfrom
farook-edev:ifeval-fixes
Open

farook-edev wants to merge 1 commit into
mlcommons:mainfrom
farook-edev:ifeval-fixes

Conversation

@farook-edev

Copy link
Copy Markdown
Contributor

this PR adds a couple fixes from mobile_app_open's ifeval. First, the Character counting instead of byte counting. Second, it removes special tokens before running the evaluation

@farook-edev
farook-edev requested review from a team and anhappdev as code owners November 10, 2026 00:56
@github-actions

Copy link
Copy Markdown

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@freedomtan

Copy link
Copy Markdown
Contributor

@AhmedTElthakeb please take a look at this one.

@AhmedTElthakeb

Copy link
Copy Markdown

Couple comments on the special-token removal part:

  • I do not recommend to change the reference python implementation (generally) and specially for this case, I would rather try to strip the special tokens in the response generate pipeline (e.g. detokenize with skip_special_tokens) or in a separate preprocessing step, and keep the reference python as identical to google-research.

  • Also, the token list is model-specific and incomplete in this case. It covers some special tokens <pad>/<eos>/<bos>/<mask>, but misses Gemma's most special tokens such as <start_of_turn>/<end_of_turn>. Doing this at the tokenizer level, which knows its own special tokens, avoids keeping a hard coded list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants