Skip to content

Update coco.py to not utilize os.system#2489

Open
arav-agarwal2 wants to merge 7 commits intomlcommons:masterfrom
arav-agarwal2:arav-patch-004
Open

Update coco.py to not utilize os.system#2489
arav-agarwal2 wants to merge 7 commits intomlcommons:masterfrom
arav-agarwal2:arav-patch-004

Conversation

@arav-agarwal2
Copy link

Remove potentially dangerous calls to os.system in favor of safer shutil/requests based alternatives.

@arav-agarwal2 arav-agarwal2 requested a review from a team as a code owner February 4, 2026 21:10
@github-actions
Copy link
Contributor

github-actions bot commented Feb 4, 2026

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@arjunsuresh
Copy link
Contributor

@arav-agarwal2 Thank you for the change. Can this code be made Windows compatible as well? Since we are in code freeze window this will likely be merged only after the inference submission deadline.

@arav-agarwal2
Copy link
Author

arav-agarwal2 commented Feb 5, 2026

As it currently stands, I'd wait on getting Windows support unless there's present need to do so. Between the fact that I know most Windows ML-facing devs use WSL or another compatibility layer and the fact that running coco.py using the README's instructions involves running a bash script, I'm not sure how much demand there is.

I'm totally happy to wait; I'm working on a variety of code quality updates so as long as it's okay for me to make more PRs, I'm more than ok with them sitting un-merged.

@arjunsuresh
Copy link
Contributor

I don't think there's much demand for Windows - but most of the vision MLPerf code works on Windows. And if it's just a 5 minutes change it's worth it as the code is in Python.

@arav-agarwal2
Copy link
Author

Sorry for the delay - I had to spend a little more time than I'd like to get the paths OS-agnostic using pathlib, but it should be working now.

@arjunsuresh
Copy link
Contributor

Thanks a lot @arav-agarwal2 We can get this merged in two weeks once submissions are done. Since you're trying to make the code better, copilot can be useful in saving time.

@tanvi-mlcommons
Copy link
Contributor

issue #2502

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments