Repository navigation
fix: reject accuracy entries scored incompletely (complete: false) - #188
Closed
pgmpablo157321 wants to merge 1 commit into
Closed
pgmpablo157321 wants to merge 1 commit into
pgmpablo157321 wants to merge 1 commit into
Conversation
When LiveCodeBench cannot be scored, LegacyMLPerfDeepSeekR1Scorer writes a score from the text subsets alone and flags the entry complete: false. The accuracy gate never read that flag, so the partial score was gated as the full one and could pass. Report an accuracy-gate error naming every entry with complete: false and skip the threshold comparison. Fixes #174 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #174
Problem
When LiveCodeBench cannot be scored, the client's
LegacyMLPerfDeepSeekR1Scorerwrites a non-null score from the text subsets only and setscomplete: false. The CLI never readcomplete, so_gate_accuracygated the partial score as the full aggregate, and it could pass.Change
_gate_accuracy(models/aggregate/context.py) now checks every entry forcomplete: false. It reports anaccuracy-gate/incomplete-datasetserror naming those entries and skips the threshold comparison. It sits alongside the null-score check from fix: reject incomplete accuracy aggregates with null scores #170; an entry with both a null score andcomplete: falsegets both errors.data/messages.yaml.Notes:
complete: falsecounts as incomplete. A missingcompletefield is gated as before, so older result files keep working._dataset_score) also ignorescomplete.Tests
accuracy_scoreslayouts, and an entry withcomplete: trueis still gated normally.mainin my local environment, so they look like missing dependencies there rather than this change.🤖 Generated with Claude Code