Repository navigation
Remove seed-config-legacy rule - #186
Open
anandhu-eng wants to merge 1 commit into
Open
anandhu-eng wants to merge 1 commit into
anandhu-eng wants to merge 1 commit into
Conversation
A point with no seed_set is already rejected by point-disclosure-complete. The legacy rule added a warning when the seeds were 42, which read as if 42 were a valid fallback. §4.6 and §9.1 have no such fallback. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues were identified for the change removing the legacy seed-value rule.
No open issues 🎉
What changed in this PR
Removes the legacy seed-value rule so points without a seed_set rely on the existing disclosure error, without suggesting that seed 42 is an accepted fallback. Such points remain rejected.
Changes:
- Removes the legacy validator and its messages.
- Adds regression coverage for missing
seed_setwith seeds 42 and 7. - Removes the obsolete rule from the README.
| File | Description |
|---|---|
tests/submission_checker/test_checks_file.py |
Verifies one disclosure error and no seed-value checks when seed_set is missing. |
src/submission_checker/models/file/point_config.py |
Removes the legacy seed validator. |
src/submission_checker/data/messages.yaml |
Removes legacy seed error and warning messages. |
README.md |
Removes the legacy rule’s documentation row. |
Review effort: Balanced
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #163
A point with no
seed_setis already an error frompoint-disclosure-complete. Theseed-config-legacyrule then added a second result: a warning if the seeds were 42, an error otherwise. The warning made 42 look like an accepted fallback. The rules (§4.6, §9.1) have no fallback: every point must record a published seed set.Changes:
seed-config-legacycheck, its messages, and its README row.seed_setgets one disclosure error and no seed-value check, for seed 42 and for any other value.The verdict does not change. Such a point was rejected before and is still rejected.
🤖 Generated with Claude Code