Repository navigation
docs: quote the current §4.6 and §9.1 text for the seed adoption window - #185
Open
anandhu-eng wants to merge 1 commit into
Open
anandhu-eng wants to merge 1 commit into
anandhu-eng wants to merge 1 commit into
Conversation
The adoption_window docstring quoted "four consecutive cohorts — its publication cohort and the following three", which is not in the rules. It now quotes §4.6 and the §9.1 check that sets the window. The module docstring and the seed_sets.yaml header are updated to match. No logic change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are reported for the documentation update clarifying the seed-adoption window.
No open issues 🎉
What changed in this PR
Updates seed-adoption-window documentation to use the published rules’ wording, addressing #164 without changing behavior.
Changes:
- Replaces the inaccurate §4.6 quotation with the current text.
- Cites §9.1 to clarify that adoption includes the publication cohort and the next three cohorts.
- Aligns the module docstring and seed-set header comments with these references.
| File | Description |
|---|---|
src/submission_checker/data/seed_sets.yaml |
Updates the header comment to cite both sections for the adoption window. |
src/submission_checker/cohorts.py |
Corrects the §4.6 quotations and adds §9.1’s justification for the existing window. |
Review effort: Balanced
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #164.
The
adoption_windowdocstring quoted §4.6 as "four consecutive cohorts — its publication cohort and the following three". That sentence is not in the rules, and never was in the file's history.The docstring now quotes the rules as written:
target_cohortor one of the three immediately preceding cohorts".§9.1 settles that the window is the publication cohort plus the three after it. That matches the code and the published
seedset.yaml(set B:2026-11-C0to2026-12-C1).The same paraphrase is also fixed in the
cohorts.pymodule docstring and theseed_sets.yamlheader. No logic change. Tests, ruff and mypy pass.🤖 Generated with Claude Code