Skip to content

test: honor configured release candidate version #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stefan-jansen merged 1 commit into from
Sep 10, 2026
Merged

test: honor configured release candidate version #83

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions tests/unit/test_artifact_qualification.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ def test_metadata_contract_accepts_declared_stable_candidate() -> None:
project = tomllib.load(stream)["project"]
message = email.message.Message()
message["Name"] = "ml4t-live"
message["Version"] = "0.1.1"
message["Version"] = qualify_artifacts.CANDIDATE_VERSION
message["Requires-Python"] = ">=3.12"
message["License-Expression"] = "MIT"
message["Summary"] = EXPECTED_DESCRIPTION
Expand All @@ -93,15 +93,15 @@ def test_metadata_contract_accepts_declared_stable_candidate() -> None:
for dependency in project["dependencies"]:
message["Requires-Dist"] = dependency

assert validate_metadata(message, project) == "0.1.1"
assert validate_metadata(message, project) == qualify_artifacts.CANDIDATE_VERSION


def test_metadata_contract_rejects_noncanonical_identity() -> None:
with (REPOSITORY_ROOT / "pyproject.toml").open("rb") as stream:
project = tomllib.load(stream)["project"]
message = email.message.Message()
message["Name"] = "ml4t-live"
message["Version"] = "0.1.1"
message["Version"] = qualify_artifacts.CANDIDATE_VERSION
message["Requires-Python"] = ">=3.12"
message["License-Expression"] = "MIT"
message["Summary"] = "Generic live trading package"
Expand All @@ -124,7 +124,7 @@ def test_metadata_contract_rejects_development_build_of_stable_candidate() -> No
project = tomllib.load(stream)["project"]
message = email.message.Message()
message["Name"] = "ml4t-live"
message["Version"] = "0.1.1.dev1"
message["Version"] = f"{qualify_artifacts.CANDIDATE_VERSION}.dev1"
message["Requires-Python"] = ">=3.12"
message["License-Expression"] = "MIT"
message["Summary"] = EXPECTED_DESCRIPTION
Expand All @@ -145,7 +145,7 @@ def test_metadata_contract_rejects_development_build_of_stable_candidate() -> No
def test_metadata_contract_rejects_python_315_upper_bound() -> None:
message = email.message.Message()
message["Name"] = "ml4t-live"
message["Version"] = "0.1.1"
message["Version"] = qualify_artifacts.CANDIDATE_VERSION
message["Requires-Python"] = ">=3.12,<3.15"
message["License-Expression"] = "MIT"

Expand Down
10 changes: 6 additions & 4 deletions tests/unit/test_stable_gate.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

from __future__ import annotations

import os
import runpy
from collections.abc import Callable, Sequence
from pathlib import Path
Expand Down Expand Up @@ -47,6 +48,7 @@ def test_gate_has_explicit_topology_and_rotates_critical_fault_order(tmp_path: P
stages = qualification_stages(tmp_path, 5)
names = [stage.name for stage in stages]
critical = [stage for stage in stages if stage.name.startswith("critical-faults-")]
candidate_version = os.environ.get("SETUPTOOLS_SCM_PRETEND_VERSION", "0.1.1")

assert names[:12] == [
"ruff-format",
Expand Down Expand Up @@ -74,16 +76,16 @@ def test_gate_has_explicit_topology_and_rotates_critical_fault_order(tmp_path: P
assert len({stage.command[6] for stage in critical}) == 5
by_name = {stage.name: stage for stage in stages}
assert by_name["dependency-compatibility"].environment == {
"SETUPTOOLS_SCM_PRETEND_VERSION": "0.1.1"
"SETUPTOOLS_SCM_PRETEND_VERSION": candidate_version
}
assert by_name["artifact-qualification"].environment == {
"SETUPTOOLS_SCM_PRETEND_VERSION": "0.1.1"
"SETUPTOOLS_SCM_PRETEND_VERSION": candidate_version
}
assert by_name["security-qualification"].environment == {
"SETUPTOOLS_SCM_PRETEND_VERSION": "0.1.1"
"SETUPTOOLS_SCM_PRETEND_VERSION": candidate_version
}
assert by_name["build"].environment == {
"SETUPTOOLS_SCM_PRETEND_VERSION": "0.1.1",
"SETUPTOOLS_SCM_PRETEND_VERSION": candidate_version,
"SOURCE_DATE_EPOCH": NAMESPACE["source_date_epoch"](),
}

Expand Down