ml4t-coursework 0.3.0 - #6
Merged
Merged
Conversation
The long panel, the runner, market specs, and contracts that no longer name a Foundations unit. data_panel returns (date, asset) rows with a close column instead of a wide frame, which is why this is a minor bump rather than a patch: anything calling it has to unstack. setup() also falls back instead of raising where google.colab imports but no Drive can be mounted, which is what blocks three Foundations notebooks on the published Colab image today. The version is declared in two places and a test now compares them: the run row records the module's value, the wheel metadata carries pyproject's, and the release workflow only checks the tag against the module.
tomllib is 3.11+ and this package supports 3.10, so the first version failed the matrix on every platform. Reading importlib.metadata compares the module against what pip reports, which is the number that matters and also catches a build stale against the source.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps the version and adds the test that keeps the two declarations from drifting.
data_panelnow returns(date, asset)rows with aclosecolumn rather than a wide frame, so this is a minor bump: any caller has to unstack. The runner, theMarketSpecregistry withetfs, and the removal of Foundations unit ids from the contracts ride along.setup()also falls back instead of raising wheregoogle.colabimports but no Drive can be mounted - the failure that blocks Foundations units 1.3, 1.4 and 3.1 on the published Colab image.Tag
v0.3.0after this merges; the release workflow qualifies and publishes.