Open
Conversation
Open
2 tasks
Collaborator
|
@rittaneg86 Please review the changes made here and let me know your thoughts |
brownsarahm
requested changes
Aug 15, 2025
Contributor
brownsarahm
left a comment
brownsarahm
left a comment
There was a problem hiding this comment.
some clean up level fixes
also add a readme to this folder that describes each file
|
|
||
| # loading the performance results | ||
| perf_path = '../results_manually_combined' | ||
| perf_path = '/project/pi_brownsarahm_uri_edu/ayman_uri/fairnessBench/results_final_total' |
Contributor
There was a problem hiding this comment.
let's put these absolute paths in an ignored file, paths.py and then add a readme that indicates what should be in that file
| ax.axvline(x=1.0, color='black', linestyle='-.', alpha=0.2) | ||
|
|
||
| # saving the plot | ||
| os.chdir('graphs/') |
Contributor
There was a problem hiding this comment.
use os.path.join to construct variables for the paths and do not use chdir
Contributor
There was a problem hiding this comment.
lets not have results in the repo
Collaborator
Author
|
@brownsarahm i worked on the changes you requested. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, pushed the analysis files. you just have to do python .......py. i did put relative paths but you can just check to put your paths.