Normalize scheduler/warmup step-like arguments by grad_accumulation_steps; warmup-only configuration, sane argument defaults and tests #582
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
100, with gradient accumulation of32steps will now last for100steps instead of100*32steps. This should be more intuitive for users.constantwhenwarmup > 0, making warmup-only configs simpler.KeyError("name")to surface misconfigurations early.Grad accumulation normalization:
warmup: stepslinear_schedule: stepscosine_decay: decay_stepsstep_decay: step_sizeeffective_steps = ceil(config_steps / max(1, grad_accumulation_steps)), with a minimum of 1.Tests:
Behavioral notes:
ValueErroras before.Minor improvements:
muonto--optimizerhelp text--learning-ratehelp text from "Adam learning rate." to "Optimizer learning rate." since it applies to more than just Adamlr_scheduleconfiguration discoverability and documentationFrom:
To:
Added reference to config and docs where the scheduler is built: