fix(security): harden shell command evaluation and fix test isolation#763
Open
pg-adm1n wants to merge 2 commits into
Open
fix(security): harden shell command evaluation and fix test isolation#763pg-adm1n wants to merge 2 commits into
pg-adm1n wants to merge 2 commits into
Conversation
- Harden splitChainedCommands to split on newlines and single ampersands - Implement recursive subshell command extraction for `` and `\`...\`` - Refactor evaluateCommand to validate allowed commands segment-by-segment - Update caseInsensitive default to true on macOS (darwin) - Add codexHome isolation override to project-dir-strict integration test - Rebuild CLI, server, and security bundles with the security fixes
pg-adm1n
force-pushed
the
fix/hardened-command-security
branch
from
222c212 to
7568ae3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR hardens the context-mode security policy engine to resolve three major logical bypasses in shell command screening:
$()and\...`are now recursively extracted viaextractSubshellCommands` and evaluated against the security policy.~/.codexlogs.All 4080 unit and integration tests pass successfully.