fix(codex): make marketplace MCP bootstrap self-contained#762
Open
TyceHerrman wants to merge 2 commits into
Open
fix(codex): make marketplace MCP bootstrap self-contained#762TyceHerrman wants to merge 2 commits into
TyceHerrman wants to merge 2 commits into
Conversation
Package vendored dependencies for the Codex plugin launcher, add marketplace self-containment tests, and document/probe the plugin install state. Co-authored-by: Codex <noreply@openai.com>
Owner
|
@TyceHerrman CI |
mksglu
reviewed
Jun 1, 2026
Contributor
Author
There was a problem hiding this comment.
it was a temporary esbuild entrypoint so the Codex marketplace artifact could generate physical .codex-plugin/vendor/* bundles for turndown and turndown-plugin-gfm without shipping node_modules. updated with scripts/build-codex-vendor.mjs, which explicitly resolves the packages and builds the Codex-only vendor bundles.
mksglu
requested changes
Jun 1, 2026
mksglu
requested changes
Jun 3, 2026
Owner
There was a problem hiding this comment.
Hi @TyceHerrman! Thanks a lot for the PR. So what's these files actually? Please could you provide me more information about that and other file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What / Why / How
Make the Codex marketplace MCP bootstrap self-contained enough to start from the installed plugin directory without a separate global
context-modeinstall or a first-runnode_modulesdependency install.This keeps Codex on a Codex-specific launcher at
.codex-plugin/plugin-start.mjs. The launcher validates the packaged artifact, wires bundled pure-JS runtime dependencies forturndownandturndown-plugin-gfm, preserves Codex MCP env/approval metadata, then importsserver.bundle.mjs. It also adds a Codex doctor probe that starts the plugin MCP command from.codex-plugin/mcp.jsonand verifiestools/listexposesctx_*.Affected platforms
Test plan
Added/updated tests for:
node_modules..codex-plugin/plugin-start.mjs, vendored runtime files, andserver.bundle.mjs.Verification run on latest base:
git diff --checknpm pack --dry-run --json --cache /private/tmp/context-mode-npm-cacheplus explicit package file checkLocal caveat:
npm run buildand focused Vitest were attempted after the latest rebase, but the local repo'sesbuildbinary hangs even on--version, and Vitest also hung without output.cli.bundle.mjswas regenerated with a working esbuild0.27.7binary from an installed context-mode package. Earlier focused Codex/plugin tests passed before the latest upstream refresh.Checklist
npm testpassesnpm run typecheckpassesnextbranch (unless hotfix)Cross-platform notes
The Codex launcher uses Node path helpers (
resolve,join,fileURLToPath) for filesystem paths. The manifest keeps Codex's existingcwd,env.CONTEXT_MODE_PLATFORM, anddefault_tools_approval_modefields while changing only the launcher args to the Codex-specific bootstrap.