Skip to content

Add --noob onboarding-context mode to pr-approval skill - #7

Open
martensonbj wants to merge 1 commit into
mkitt:mainfrom
martensonbj:pr-approval-noob-mode
Open

Add --noob onboarding-context mode to pr-approval skill#7
martensonbj wants to merge 1 commit into
mkitt:mainfrom
martensonbj:pr-approval-noob-mode

Conversation

@martensonbj

Copy link
Copy Markdown

What

Adds an opt-in --noob flag (alias --eli5) to the pr-approval skill's review mode.

When set, each per-PR analyst card opens with an "ELI5 & how we got here" block:

  • ELI5 the intent — ≤ 3 plain sentences on what the PR is actually trying to do, acronyms expanded.
  • How we got here — ≤ 4 one-line steps naming the predecessor issues / PRs / ADRs and the one thing each contributed.

Off by default; ignored in triage (kept as a cheap, no-deep-read sweep); length-capped (~150 words) so it leads a decision card rather than turning into a wiki page.

Why

Reviewers rotate onto repos and bodies of work they're new to. A diff shows what changed but not the arc that made the change necessary — a feature that was "done on paper" a few tickets ago but never actually ran, an infra blocker fixed out-of-band, a superseded approach. That lineage usually lives only in the author's head or scattered across tickets. --noob surfaces it inline so someone reviewing cold can trust their call, without adding noise for reviewers who already have the context (hence off-by-default).

How it flows

R1 parses the flag → R2 walks the Linear "Follows / Context" lineage (not just the PR's own issue) → R3 hands the analyst the traced lineage + the instruction → R4 renders the block first in each card (context before verdict).

Validation

Tried live on two stacked PRs (an experimental-harness install + its follow-up). The block correctly surfaced context invisible in the diffs — e.g. "this feature was marked done three tickets ago but never actually ran because the binary was missing from the sandbox image." Tightened the length cap after a first pass came out wiki-length.

🤖 Generated with Claude Code

Adds an opt-in --noob flag (alias --eli5) for review mode. When set, each
per-PR analyst card opens with an "ELI5 & how we got here" block: a plain-
language statement of what the PR is trying to do, plus a short lineage of the
predecessor issues / PRs / ADRs that made it necessary -- context a first-time
reader of the repo can't reconstruct from the diff alone.

Off by default and ignored in triage (which stays a cheap, no-deep-read sweep).
Length-capped so it leads a decision card, not a wiki page.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant