Return non-zero exit code when download errors occur with --ignore-errors #257
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The download command returns exit code 0 even when errors are logged, preventing scripts from detecting failures when using
--ignore-errors.Changes
_errorscounter toDownloadCounterclass withcount_error()methodconsume(): exceptions during async download tasksdownload_cover(): missing cover URLs1whencounter.errors > 0at end of download commandBehavior
Without
--ignore-errors, behavior unchanged (exception → exit 1/2). Successful downloads still exit 0.Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.