Repository navigation
Verify failed board posts from killed swarm members - #18
Merged
Merged
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Owner
Author
|
Integrated by fast-forward. The reviewed commit b5ba504 is on main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a swarm member is killed before its board post reaches the board, agy records a failed
post_messagewith no result payload. The reader previously skipped the entire conversation, leaving an older transcript on disk.The verifier now accepts that failure when the stored text matches the tool call and both error messages identify the same killed member. It compares the complete step with the daemon presentation. Regression tests cover the accepted case, altered text, mismatched errors, extra arguments, and an unexpected result payload.
In a live store, the watcher replaced a three-step sidecar with all 86 verified steps. Its next full check reported 500 sessions up to date, zero skipped, and zero failed. Offline export, the Go tests, vet, and lint also passed.