Skip to content

Support agy 1.5.9 workflows and plan tools - #13

Merged
mjacobs merged 5 commits into
mainfrom
review/agy-1.5.9
Nov 15, 2026
Merged

mjacobs merged 5 commits into
mainfrom
review/agy-1.5.9

Conversation

@mjacobs

@mjacobs mjacobs commented Nov 15, 2026

Copy link
Copy Markdown
Owner

Sessions using plan-mode tools and run_workflow stopped syncing, and workflow
children were refused on a newly persisted title field. This change qualifies
the observed agy 1.5.9 forms, preserves their complete stored content, and links
workflow children to the correct parent call.

Design

  • Retain a verified protobuf snapshot and add only the authenticated child-title
    field to the historical decoder bundle.
  • Validate successful and failed workflow wrappers against both full and default
    RPC responses, including saved arguments, errors and render information.
  • Resolve workflow ancestry and Markdown placement from matching source and
    invocation metadata. Preserve all turns of reusable workers.
  • Reject unknown fields, mismatched arguments and unqualified wrapper forms.

Verification and limits

  • Formatting, vet, lint, Go tests, race tests and all 185 protobuf-enabled Python
    maintenance tests pass. Independent Wu review is complete with no open findings.
  • The completed 310-step exercise conversation and all six children pass sync
    and Markdown checks. All four workflow workers appear at their originating call.
  • A fresh 507-conversation sweep fetches and renders every source; 506 pass native
    verification and match offline steps and generator/executor metadata. One
    historical failed board post remains unsupported.
  • Browser MP4 behavior and other unexercised schema additions remain unqualified.
    The report distinguishes the observed doctor cost from a proven regression.

The generated compatibility record names agy 1.5.9 and the clean implementation
commit. Private session captures and logs are excluded. This PR does not install
the reader, restart services or publish a release.

Preserve workflow child titles and qualify the observed successful and failed
workflow results without dropping their stored scripts, output or errors.
Resolve and place children only when their explicit source metadata matches
the parent workflow call.

Verify the completed 310-step self-analysis session and all six children.
The 507-source sweep verifies 506 sources; the existing failed board post
remains refused. Offline exports match all 506 verified sources. Formatting,
vet, lint, Go and race tests, and all 185 Python maintenance tests pass.
Record the unchanged SQLite schema and inspected sidecar shape drift from a
fresh 507-source corpus. Native qualification covers 506 sources, including
the completed self-analysis conversation and all six children; the retained
historical failed board post remains explicitly unsupported.
Explain why an image-read allowlist does not prove a browser recording
regression, and distinguish full doctor verification cost from the watcher
cache. Keep both observations separate from the qualified workflow fixes.
Correct the cache lifetime explanation: watch can reload saved verification
results after a restart within the same boot. Link the existing cache
measurement and retain the distinction from full doctor verification.

The existing restart, invalidation and disk compatibility tests pass.
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 15, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-15T08:24:10.497627Z 899c953 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@mjacobs
mjacobs merged commit 899c953 into main Nov 15, 2026
3 checks passed
@mjacobs
mjacobs deleted the review/agy-1.5.9 branch November 15, 2026 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant