DMT 2.4.9: Magento 2.4.9 compatibility#1
Open
miyelabs wants to merge 5 commits into
Open
Conversation
Bump version to 2.4.9 and add changelog entry for Magento Open Source and Adobe Commerce 2.4.9 support. https://claude.ai/code/session_015Y1Wix1FL2gJX27KoQ8N9J
- Bump version to 2.4.9 - Add PHP ~8.3.0||~8.4.0||~8.5.0 constraint - Update symfony/console from ^6.4 to ^7.4 - Update phpunit from ~9.5.0 to ^12.0 - Fix PHP 8.4 implicit nullable params: ?Document, ?\Zend_Db_Expr - Add Symfony 7 return types to console command methods - Update PHPUnit XML schemas to v12.0 https://claude.ai/code/session_015Y1Wix1FL2gJX27KoQ8N9J
- ConsoleOutputFactory: ?OutputFormatterInterface $formatter = null - Customer/Data: array $attributesToSkip = [] (was = null); update dead null-check to !empty() https://claude.ai/code/session_015Y1Wix1FL2gJX27KoQ8N9J
PHPUnit 10+ requires explicit void return type on setUp() and tearDown() — fixes 24 test files. https://claude.ai/code/session_015Y1Wix1FL2gJX27KoQ8N9J
PR magento#929: Fix EAV duplicate entry '11-general' constraint violation - Add getEntityAttributeSets() for generic entity type support - Add getDefaultEntityAttributeGroups() replacing product-specific logic - Refactor getCustomAttributeGroups() to use new generic methods Issue magento#934: Prevent duplicate gallery rows in InsertValueToEntity - Check for existing (value_id, entity_id) pair before inserting - Prevents catalog_product_entity_media_gallery_value_to_entity bloat https://claude.ai/code/session_015Y1Wix1FL2gJX27KoQ8N9J
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
2.4.9, add PHP~8.3.0||~8.4.0||~8.5.0constraint, updatesymfony/consolefrom^6.4to^7.4, updatephpunitfrom~9.5.0to^12.0?Document,?\Zend_Db_Expr,?OutputFormatterInterface,array = []) across 5 filesvoid/int) to all command methods: voidtosetUp()/tearDown()in 24 unit test filesgetEntityAttributeSets,getDefaultEntityAttributeGroups, refactorgetCustomAttributeGroups)(value_id, entity_id)before inserting inInsertValueToEntityTest plan
vendor/bin/phpunit -c tests/unit/phpunit.xml.distcatalog_product_entity_media_gallery_value_to_entity2.4.9on the merge commit and confirmcomposer require magento/data-migration-tool:2.4.9resolvesGenerated by Claude Code