Conversation
dsubak
added this pull request to stack #3970
September 15, 2026 19:08
OpenAPI ChangesShow/hide changesUnexpected changes? Ensure your branch is up-to-date with |
dsubak
force-pushed
the
dansubak/202609_add_data_consent_fields_to_through_model_pt_2
branch
from
September 15, 2026 19:11
4706770 to
3e9025b
Compare
dsubak
force-pushed
the
dansubak/202609_add_data_consent_fields_to_through_model_pt_2
branch
from
September 16, 2026 13:06
3e9025b to
e6665d0
Compare
dsubak
force-pushed
the
dansubak/202609_add_data_consent_fields_to_through_model_pt_2
branch
from
September 17, 2026 18:45
e6665d0 to
e09a539
Compare
dsubak
force-pushed
the
dansubak/202609_add_data_consent_fields_to_through_model_pt_2
branch
from
September 17, 2026 20:44
e09a539 to
b8e54d3
Compare
dsubak
force-pushed
the
dansubak/202609_add_data_consent_fields_to_through_model_pt_2
branch
from
September 18, 2026 20:48
b8e54d3 to
5a0ac54
Compare
jkachel
requested changes
Sep 18, 2026
jkachel
left a comment
Contributor
There was a problem hiding this comment.
Small change - should be good to go once that's fixed, though.
dsubak
force-pushed
the
dansubak/202609_add_data_consent_fields_to_through_model_pt_2
branch
from
September 22, 2026 13:06
5a0ac54 to
fb2dcf8
Compare
jkachel
approved these changes
Sep 22, 2026
jkachel
left a comment
Contributor
There was a problem hiding this comment.
LGTM 👍 did test on an instance that didn't have the pt1 migrations applied yet
dsubak
force-pushed
the
dansubak/202609_add_data_consent_fields_to_through_model_pt_2
branch
from
September 23, 2026 13:41
0cb739f to
802cded
Compare
Base automatically changed from
dansubak/202609_add_data_consent_fields_to_through_model
to
main
September 23, 2026 13:51
dsubak
force-pushed
the
dansubak/202609_add_data_consent_fields_to_through_model_pt_2
branch
from
September 23, 2026 13:51
802cded to
239258e
Compare
dsubak
force-pushed
the
dansubak/202609_add_data_consent_fields_to_through_model_pt_2
branch
from
September 23, 2026 21:13
239258e to
fd4c9f9
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What are the relevant tickets?
https://github.com/mitodl/hq/issues/13262
Description (What does it do?)
This adds the fields we actually care about adding on the b2b contracts m2m through model, namely a boolean tracking data consent and a timestamp for when it was recorded. It also adds row level modification and and created timestamps (technically unnecessary at the moment, could be useful later if we end up adding more fields).
How can this be tested?
Migration should apply without issue. There's no users of this functionality yet, so that's about all that we should expect!
Additional Context
This is a stacked PR on top of the changes that just add the new through model and perform a table rename. I could squish these into one big migration if we'd like, but I think it's nicer to have that separate since the first one is spookier than this one.
Also worth noting is that we have a temporary default created on timestamp specified in the migration. That's because TimestampedModel adds created_on as a non-nullable field. Perfectly reasonable for a net new model, slightly misleading for models which already have records in the table - the practical outcome of this is that all extant records will have the same datetime set. If people don't like that, let me know!