Release 1.162.9

[odlbot]

James Kachel

• Add manual order completion; refactor Stripe event handling (Add manual order completion; refactor Stripe event handling #3855) (99171d22)

cp-at-mit

• Enforce one product per purchasable object (Enforce one product per purchasable object #3847) (013bedb9)

Tobias Macey

• chore(otel): delete a dead flag and fix a setting name that was never read (chore(otel): delete a dead flag and fix a setting name that was never read #3859) (00402e0d)

[gitguardian]

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request

GitGuardian id	GitGuardian status	Secret	Commit	Filename
36131093	Triggered	Generic High Entropy Secret	99171d2	ecommerce/fixtures.py	View secret

🛠 Guidelines to remediate hardcoded secrets

1. Understand the implications of revoking this secret by investigating where it is used in your code.
2. Replace and store your secret safely. Learn here the best practices.
3. Revoke and rotate this secret.
4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

• following these best practices for managing and storing secrets including API keys and other credentials
• install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.

---

^{🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.}

[github-actions]

OpenAPI Changes

Show/hide changes

## Changes for v0.yaml:
No changes to report, but the specs are different.
Run 'oasdiff diff' to see structural differences.

## Changes for v1.yaml:
No changes to report, but the specs are different.
Run 'oasdiff diff' to see structural differences.

## Changes for v2.yaml:
No changes to report, but the specs are different.
Run 'oasdiff diff' to see structural differences.

Unexpected changes? Ensure your branch is up-to-date with main (consider rebasing).

[sentry]

Bug: The Celery task process_pending_order_resolutions calls check_and_process_pending_orders_for_resolution without the required refnos argument, which will cause a TypeError.
_{Severity: CRITICAL}

Suggested Fix

Update the process_pending_order_resolutions Celery task to correctly call check_and_process_pending_orders_for_resolution. Similar to the updated management command, this likely involves initializing an empty list for refnos and passing it to the function.

Prompt for AI Agent

Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.

Location: ecommerce/api.py#L744-L747

Potential issue: The function signature for
`check_and_process_pending_orders_for_resolution` was changed, making the `refnos`
parameter a required positional argument. However, the Celery task
`process_pending_order_resolutions` in `ecommerce/tasks.py` was not updated and still
calls this function without any arguments. Because this is a scheduled Celery task, it
will run periodically in production and raise a `TypeError` on every execution, as it is
missing the required `refnos` argument.

_{Did we get this right? 👍 / 👎 to inform future reviews.}

[jkachel]

Closing to get a fix for a migration in place. This never deployed.