Release 1.150.0 - #3571
Merged
Merged
Release 1.150.0#3571
Conversation
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…3562) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
OpenAPI ChangesShow/hide ## Changes for v0.yaml:Unexpected changes? Ensure your branch is up-to-date with |
| user = self.request.user | ||
| if qp.get("org_id"): | ||
| added_context["org_id"] = qp.get("org_id") | ||
| added_context["org_id"] = int(qp.get("org_id")) |
Contributor
There was a problem hiding this comment.
Bug: Direct int() conversion of org_id and contract_id query parameters without error handling can raise a ValueError if a non-integer value is provided, causing a 500 error.
Severity: HIGH
Suggested Fix
Wrap the int() conversions for org_id and contract_id in a try-except ValueError block. Handle the case where the conversion fails, for example, by using a default value or ignoring the parameter.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location: courses/views/v2/__init__.py#L454
Potential issue: In `CourseViewSet.get_serializer_context()`, the `org_id` and
`contract_id` query parameters are directly converted to integers using `int()`. If a
non-integer string is passed for either parameter, this will raise a `ValueError`. The
view's filter class silently fails on invalid input, but the unconverted string remains
in `request.query_params` and is passed to `get_serializer_context`. Since this
`ValueError` is not caught, it results in an unhandled exception and a 500 server error.
This endpoint is publicly accessible as `permission_classes = []`.
Did we get this right? 👍 / 👎 to inform future reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
renovate[bot]
annagav
Nathan Levesque
Dan Subak
Muhammad Anas