Release 0.78.2 - #3877
Merged
Merged
Release 0.78.2#3877
Conversation
…#3868) * Clear the a11y findings eslint-plugin-styled-components-a11y 2.2 adds Two are real: the contract admin table had an unlabelled columnheader, and the user menu declared role="button" on a styled.button. The other seven are deliberate patterns the rules cannot see through, so they get a scoped disable with the reason: - Card and the video-shorts player forward a body click to a control the user can already reach by keyboard (the card's own anchor, the visible PlayPauseButton). A keydown handler would duplicate it. - The video-shorts slide is the APG carousel pattern: role="group" with a roving tabindex and Enter to toggle playback. - NavDrawer is a persistent Drawer, so it is not a MUI Modal and gets no built-in Escape handling; the onKeyUp is the only keyboard exit. - The suppressed-value marker is focusable so its tooltip is reachable without a pointer; there is no action to justify a button. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FyJ72HRTyQf6jVYmw3GZSt * Correct the NavDrawer suppression rationale The comment claimed the Escape listener was the only keyboard way out of the drawer. It is not: the Close Navigation button at NavDrawer.tsx:204 is the primary exit, and this listener adds the Escape shortcut on top of it. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FyJ72HRTyQf6jVYmw3GZSt * Narrow the Card suppression rationale to its actual precondition The comments claimed the container click always forwards to the card's anchor. It only does when forwardClicksToLink is set, and that defaults to false (Card.tsx:321) -- in the other mode handleClick is the raw onClick and the container is pointer-only. Every caller today pairs the two (BaseLearningResourceCard), but nothing enforces it and Card is an ol-components export. Comment says so now; #3874 tracks making it impossible to get wrong. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FyJ72HRTyQf6jVYmw3GZSt --------- Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
actions-static-analysis.yml was already on v7.0.1 while the other three workflows sat on v6.0.1, so Renovate had two pins to chase for one action. Neither v7 breaking change applies here: the fork-checkout block only fires on pull_request_target and workflow_run, and none of these workflows use either trigger. Claude-Session: https://claude.ai/code/session_01FyJ72HRTyQf6jVYmw3GZSt Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
OpenAPI ChangesNo changes detected Unexpected changes? Ensure your branch is up-to-date with |
odlbot
added
waiting for checkboxes
all checkboxes checked
and removed
deploying to rc
waiting for checkboxes
all checkboxes checked
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dan Subak
Tobias Macey