Repository navigation
Pin h5p-author 0.13.0, and say what the chat asks now - #74
Merged
Merged
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #73.
h5p-author 0.13.0 reads a package back into its source (missing-elements/h5p-toolkit#236), so the h5p-author skill can change an
.h5pthe user has (missing-elements/h5p-toolkit#242). It also notes what builds but is almost surely a mistake (missing-elements/h5p-toolkit#241).What changes
package.jsonand the lockfile move@missing-elements/h5p-authorfrom 0.12.0 to 0.13.0. Nothing else in the lockfile changes.h5p-author.mjs, the archive and the 55 bundles now haveread, which the skill uses to change a package where npm can't be reached.references/change.md..h5pand say what to change. It says when the chat can do it: when it builds the file itself, and when the activity was made with the versions of H5P's libraries the build tool has.Tested
pnpm install --frozen-lockfileandpnpm build, which runstsc, pass. The lockfile change is 5 lines; pnpm dropped nolibc:lines.change.mdincluded. The ChatGPT zip'splugin.jsonsays 0.13.0, andbundles/index.jsonsays author 0.13.0, pack 1.1.0.H5P.Blanks.zip, reading that package stops at the addon it needs: "The parts folder parts has no H5P.MathDisplay-1.0.h5p, which this package needs".bundles/parts/H5P.MathDisplay-1.0.h5padded, it reads.vite preview, in Chromium:#source=link with a Multiple Choice that marks no answer correct built and played in 0.6 s.Summary by cubic
Pins
@missing-elements/h5p-authorto 0.13.0 so the chat can change an.h5pyou already have, and updates the guide and build page to say the chat asks for the content type at most.readcommand that turns an.h5pback into its source, which the skill uses to change a package and rebuild it..h5pand say what to change, and when the chat can do it: when it builds the file itself, and when the activity was made with the bundled versions of H5P's libraries.params.answers, so no learner can score.Written for commit 2ea8da5. Summary will update on new commits.