Repository navigation
feat(author): H5P.Row's widths and empty columns, the skill changes a package, the read in SECURITY.md - #244
Merged
Merged
Conversation
… package, the read in SECURITY.md (#242) - H5P.Row's column widths take two decimals, and a row's column may be left empty, a spacer: what H5P.com's own editor writes, H5P's content check keeps and the library plays. A layout's `decimals` patch the semantics as its `optional` does. The owner's package from H5P.com now builds again after a read (27 of 30 readable ones do). - The skill changes an .h5p the user has: SKILL.md routes to references/change.md (read with the route's tool, change the source, build it there), its description leads with it, and the package exports the new file. Checked on Haiku: 3 of 3 runs read, changed and built with the tool. - SECURITY.md names the read; the README says a build reports nothing. - The Interactive Video media test gets 20 s: it timed out once on CI.
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 10 files
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
…ackage with an addon (#242) From cubic's review of #244: - SKILL.md's description held "change: never", which YAML reads as a mapping, so the front matter did not parse: a semicolon, and apps/skills/tests/front-matter.test.ts holds every skill's front matter to what a YAML parser reads and to the Agent Skills limits. - change.md, route 3: a read that stops at an addon's part (H5P.MathDisplay) fetches it into parts/ and reads again, as a build by that route does; python3 where unzip is missing. - The missing-part error says "which this package needs", true of a read as of a build. - The README says "no telemetry"; the design says the description names a change in its first sentence. Haiku on the fixed description: 3 of 3 opened the skill, read, changed and built with the tool.
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 8 files (changes from recent commits).
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #242. Small ones before h5p-author 0.13.0 and h5p-mcp 0.2.0.
What changes
contentout. An empty column plays as an empty one (params.content === undefinedbecomes[]).decimalspatches the semantics as itsoptionaldoes.H5P.Rowgetsdecimals, andH5P.RowColumngetsoptional..h5pthe user has.SKILL.mdroutes to the newreferences/change.mdin place of steps 1 and 2, asking nothing. The package is read with the tool of the first route that holds; route 3 fetches the bundle of the type the package'sh5p.jsonnames, and route 4 cannot read one. The source is changed as asked, built by the same route, and handed over as any build.python3whereunzipis missing. A read that stops at an addon's part, such as H5P.MathDisplay where the text holds math, fetches that part intoparts/and reads again, as a build by that route does. The missing-part error says "which this package needs", true of a read as of a build..gitignorecovers its packed copy. The org site zips all ofreferences/, so its skill zips carry it as they are.Tested
quiz.h5pand the build archive and asked for two harder questions. Route 1 used a local archive whose one-file tool was built from this branch, as the org site builds it. npm was cut off, and the user's own skills and settings were left out.The description's wording decided whether the skill was opened.
content.jsonand zipped it by handWhat the 3 that opened it did: each read the package with the tool, changed its source and built it with the tool: 6 questions, the added ones of kinds the quiz has. About $0.014 a run.
The hand-over: 1 of those 3 said the package is unverified and gave the build page's line; 2 dropped both. That is the hand-over's known weakness on Haiku, and its text is unchanged here.
H5P.MathDisplay-1.0.h5p, and reads once that part is added.apps/skills' front-matter test;pnpm typecheckfor both.Found, not done here
schemaOfshows a field as the pack's semantics have it, not as a layout patches it. SoH5P.Video.mdcalls the poster required, andH5P.GameMap.mdfour fields, though the build takes all of them as optional. Patching the schema too would change those two type files, which models read, so it wants its own Haiku check.Release
h5p-author 0.13.0, then h5p-mcp 0.2.0. skills.sh serves the skill from
main, and route 2 runsnpx @latest, so a release soon after this merges keepsreadfrom being named before npm has it. The org site's pin then moves the one-file tool and the bundles to 0.13.0.Summary by cubic
Makes
h5p-authorread and rebuild packages that H5P.com's own editor writes, and lets the skill change an.h5pthe user already has instead of only authoring new content.decimalspatches semantics the wayoptionaldoes, so 27 of 30 readable owner packages build again after a read.SKILL.mdroutes to a newreferences/change.mdfor changing a package the user has: read it with the build tool, change the source, build it there. Tested on Haiku in Claude Code: all 3 runs read, changed, and built with the tool.SECURITY.mddocuments the read: an archive is untrusted, only named files are written in the package's folder, never over a file, and paths that could lead out are refused.apps/skills/tests/front-matter.test.tsholds every skill's front matter to what a YAML parser reads and to the Agent Skills limits.references/change.mdroute 3 now fetches an addon's part intoparts/and reads again when a read stops at one, and offerspython3whereunzipis missing.Written for commit 20ca2aa. Summary will update on new commits.