Repository navigation
feat(author): notes for what builds and is almost surely a mistake - #243
Merged
Merged
Conversation
) Item 4 of #219. H5P allows each, so each is a note and not a problem, and each says what to write: - no answer marked correct: Multiple Choice's answers, Multimedia Choice's options; - two answers alike as a learner reads them: Multiple Choice, a Single Choice Set question, a Summary set; - a text with no gap: Fill in the Blanks, Drag the Words, Mark the Words; - a picture with no alt text where its field is optional, in eight types (`ALT_TEXTS`, held to the pack's fields by a test). lib/mistakes.mjs runs in checkContent, so a build says them and so does a check of saved content. No type file's example says any.
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 7 files
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
…ME and design say which notes, in which types (#241) From cubic's review of #243: toLowerCase in place of toLocaleLowerCase, so a note does not change with the host's locale; the README's list qualified (the content types it looks in, answers or statements alike, an optional alt text left blank); the design says statements too, as Summary's are.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #241. Item 4 of #219.
What changes
A build notes what H5P allows and is almost surely a mistake. Each is a note, not a problem, and each says what to write:
answers, Multimedia Choice'soptions(Find the Hotspot's areas are refused already)*word*lib/mistakes.mjsruns incheckContent, so a build says them, and so does a check of saved content. The read is unchanged: it says nothing of these.ALT_TEXTS, which a test holds to the pack's fields: a picture, and an optional text beside it.blanksGapsin types.mjs is exported, so the gap rule stays H5P.Blanks' own.The skill and the MCP server already pass every note on, and each note says what to write, so neither text changes.
Tested
apps/skillsholds them to that.pnpm typecheckfor the package.Summary by cubic
Adds notes for H5P content that builds but is almost surely a mistake, closing #241 (item 4 of #219). The build now reports these instead of staying silent, and each note says what to write. Text comparison is locale-independent, so a note does not change with the host's locale.
checkContent, so both builds and checks of saved content report them.ALT_TEXTSmaps each picture-with-optional-alt-text location to its fields; a test holds it against the pack's semantics.Written for commit b672706. Summary will update on new commits.