Repository navigation
feat(author): build from an archive the person attaches, where a chat's code can download nothing - #201
Merged
Conversation
…'s code can download nothing Step 3 builds first from h5p-author-build.tar.gz where the user attached it, and where Node runs but nothing installs or downloads, the build page's route carries one fixed line offering it. design/author.md records why and the Haiku runs. Closes #200.
Contributor
There was a problem hiding this comment.
1 issue found across 2 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="design/author.md">
<violation number="1" location="design/author.md:720">
P2: The skill does not ask users to attach the archive with their first message; its only explicit request comes after a failed local build. Add an upfront recommendation to the skill, or revise this claim so users are not promised guidance they will not receive.</violation>
</file>
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
| - **Across both no-archive arms:** all six links were exact, and all six gave the source file. | ||
|
|
||
| As with the feedback line before it, a weak model drops some of what it is asked to write. | ||
| The guide therefore tells people to attach the archive with their first message. |
Contributor
There was a problem hiding this comment.
P2: The skill does not ask users to attach the archive with their first message; its only explicit request comes after a failed local build. Add an upfront recommendation to the skill, or revise this claim so users are not promised guidance they will not receive.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. At design/author.md, line 720:
<comment>The skill does not ask users to attach the archive with their first message; its only explicit request comes after a failed local build. Add an upfront recommendation to the skill, or revise this claim so users are not promised guidance they will not receive.</comment>
<file context>
@@ -681,6 +681,43 @@ to 3,000. Twenty-four things the code does not say by itself:
+ - **Across both no-archive arms:** all six links were exact, and all six gave the source file.
+
+ As with the feedback line before it, a weak model drops some of what it is asked to write.
+ The guide therefore tells people to attach the archive with their first message.
- **The skill names no product** (2026-11-12, the owner's call). Its routes were told apart by
the apps they were measured in; they now say what each needs: a shell that reaches the npm
</file context>
…er's line has a place without a link From cubic's review of #201: a path at a web address is downloaded as the package builds, which a sandbox with no network cannot do; a source that names files gets no link, so the line follows the source; design/author.md says the guide, not the skill, asks people to attach the archive up front.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #200.
ChatGPT's code can download nothing, but it builds from a file the person attaches. This PR teaches the skill to use that: an archive holding the one-file build tool and the whole library pack. The organisation's site will serve it at
/h5p/bundles/h5p-author-build.tar.gz, 14.9 MB (missing-elements/missing-elements.github.io#47).SKILL.md
--libraries parts. This needs nothing installed or fetched, and works for any type.To get the .h5p file here instead: download … (15 MB) and attach it to your next message.design/author.md
A new rule, Where nothing downloads, the person attaches the build archive. It records:
.tar.gz: a.zipwas read as a plugin;Measured on Haiku
Each run had no network, with npm cut off by a dead registry.
Across the six no-archive runs, every link was exact and every run gave the source file. So the route's words are for models that need the step written out, as ChatGPT's prompt wrote it out in the owner's test. A weak model still drops some of the offer, so the guide tells people to attach the archive with their first message.
Checks
test:unit: author 183, player 400, runtime 180, normalize 24, all passing.typecheckpasses.sync:skillis clean.Order
This ships as author 0.9.8 with #197 and #199: the archive's tool needs #199's
--versionfix. The org site's PR (#47) moves its pin to 0.9.8 and writes the archive. Until it is live, the address in this skill answers 404, so that PR should merge soon after 0.9.8 is published.Summary by cubic
Adds a build-from-archive route for chat sandboxes where the chat's code can run but can't download anything. The user attaches
h5p-author-build.tar.gz(14.9 MB, served at/h5p/bundles/h5p-author-build.tar.gz), and the skill unpacks it and builds with--libraries parts. Nothing installs or fetches, for any type. Closes #200.Changes
pathmust name a file in the sandbox, such as an attached one, since a web address is downloaded as the package builds; the offer line follows the source when no link was printed.design/author.mdrecords why the archive is.tar.gz(a.zipwas read as a plugin), that nothing passes through a server of ours, and Haiku results: 3 of 3 builds from the attached archive pass the verifier, while offer lines vary with model strength, so the guide, not the skill, tells people to attach the archive with their first message.--versionfix. The address answers 404 until the site PR merges, so that should land soon after 0.9.8 is published.Written for commit c5fcf8e. Summary will update on new commits.