Skip to content

fix(author): the 2026-11-09 skill eval's and code review's findings - #163

Merged
alekswebnet merged 3 commits into
mainfrom
fix/h5p-author-review-162
Nov 9, 2026
Merged

alekswebnet merged 3 commits into
mainfrom
fix/h5p-author-review-162

Conversation

@alekswebnet

@alekswebnet alekswebnet commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

Closes #162: every finding of the 2026-11-09 skill eval and code review, in one PR as asked.

The skill (skills/h5p-author/SKILL.md)

  • Step 3: build in a working folder of one's own, rebuild a failed source under the same name, and copy the package handed over to the asked name; never delete a file to free a name. One eval run had rm -rf'd the user's file to reuse its name.
  • Step 4: says where the report lands (<name>.verify/, --out), what to read in it, and that one run is enough: --untrusted finds nothing more, the design's call of 2026-11-01.
  • Step 5: --no-open only with a browser tool the agent already has, never a script of its own. One run spent four of its six minutes writing one.
  • The hand-over paragraph is a list now, without the over-long line.
  • "Never read a library's semantics" gives its reason.

The code (packages/author), each with a test that fails on main

  • in followed the prototype chain: a field named toString or constructor went unreported, and a file named x.constructor passed as a known type. Object.hasOwn now (generator.mjs, media.mjs).
  • A multiple of a fractional step is accepted within a rounding error. The editor's % refuses 0.3 in steps of 0.1. No library in the pack has such a step, and the content check checks none, so the departure is recorded in generator.mjs and design/author.md.
  • A downloaded address with a broken escape (%zz) keeps its name as written, instead of ending the build with a bare URIError.
  • sync-skill refuses a type file whose markers are broken (one only, either twice, the end first) instead of appending a second section. The logic moved to lib/schema.mjs (withSection) so the test can import it without running the script.
  • A source's type with a version, "H5P.Blanks 1.14", is refused with the reason: the version is the pack's newest. loadLibraries takes one because saved content names one. The pack holds no two majors of any content type, so pinning one would pin nothing.
  • The CLI parses with node:util parseArgs, as h5p-verify and h5p-embed do: --libraries=dir, -h and -v work.

The five the review raised without checking

  • Confirmed and fixed: the page's build wrote the install-only libraries before the media. writePackage now takes the media and writes them between the content and those libraries, in both builds, and the page's result has install as Node's does.
  • Confirmed and fixed: the media cache was keyed by source alone. The same file named in an image field and in a file field got the first kind's folder, type and size. It is keyed by kind and source now.
  • Dropped: a non-object copyright turning into U silently. The generator already reports it, and MediaStore is not exported.
  • Dropped: schema of an unknown type opening every part. It takes 0.39 s against 0.11 s for a known type.
  • Left as is: the page holding a download of up to 1 GiB as a Blob. Chromium keeps a large Blob on disk rather than in the page's memory, and most hosts refuse a page's download under CORS anyway. Firefox and Safari were not measured.

After the AI review (ddd94df, all four of its findings)

  • The fractional step's bound is four Number.EPSILON of the quotient, the error of three roundings. The first cut's 1e-9 let 50000000.05 pass in steps of 0.1. No on-step decimal among 800,000 sampled up to 1e9 is refused, and no half-step one passes.
  • The skill copies the package with cp -n. Where the asked name is taken, it asks, or takes a new name and says so.
  • It reads the report's reasons, where a failed run may be the only field that says why.
  • It hands over the report, screenshot and revision of the run that passed, or none, with the package called unverified, where the verifier could not run.

Checks

  • pnpm typecheck and pnpm test in packages/author, the Chromium page test included.
  • apps/skills' tests.
  • sync-skill --check: 0 files out of date.
  • All ten changed or new tests fail with the library code of main.

The page build's result type gains a field and the CLI accepts more forms, so the release is an h5p-author minor. Not bumped here.

The skill: build in a working folder and copy the package to the asked
name, never delete a file to free one; name where the verifier's report
lands and that one run is enough; play the preview only with a browser
tool the agent already has; the hand-over as a list; the reason not to
read a library's semantics.

The package: own keys only where a field or a file type is looked up
(toString, x.constructor); a multiple of a fractional step within a
rounding error; a download whose address has a broken escape keeps its
name; sync-skill refuses broken markers instead of appending a second
section; a source's type with a version says the version is the pack's;
the command line through parseArgs (--libraries=dir, -h, -v); the
page's build writes the media before the libraries carried for an H5P
site's upload check, as Node's does, and returns install; the media
cache by kind and source.

Closes #162
@alekswebnet alekswebnet added bug Something isn't working documentation Improvements or additions to documentation labels Nov 8, 2026

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 15 files

Reply with feedback, questions, or to request a fix.

View guided diff | Turn on auto-fix | Re-trigger cubic

Comment thread packages/author/lib/generator.mjs Resolved
Comment thread skills/h5p-author/SKILL.md Resolved
Comment thread skills/h5p-author/SKILL.md Resolved
Comment thread skills/h5p-author/SKILL.md Resolved
A fractional step's bound is four Number.EPSILON of the quotient, the
error of three roundings, not 1e-9 of it, which let 50000000.05 pass in
steps of 0.1. The skill copies the package handed over with cp -n and
asks, or takes a new name and says so, where the asked one is taken;
reads the report's reasons, where a failed run may be the only one to
say why; and hands over the report, screenshot and revision of the run
that passed, or none, with the package called unverified, where the
verifier could not run.
@alekswebnet alekswebnet self-assigned this Nov 8, 2026

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 3 files (changes from recent commits).

Reply with feedback, questions, or to request a fix.

View guided diff | Turn on auto-fix | Re-trigger cubic

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="skills/h5p-author/SKILL.md">

<violation number="1" location="skills/h5p-author/SKILL.md:124">
P2: This leaves a failed check's handoff undefined: the package is still delivered, but the report clause covers only a passing run and the no-report exception covers only checks that could not run. Specify that a failed check must be disclosed with its report and reasons, and label the package as failed verification.</violation>
</file>

Comment thread skills/h5p-author/SKILL.md Resolved
Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com>
@alekswebnet
alekswebnet merged commit 3fd135f into main Nov 9, 2026
9 checks passed
@alekswebnet
alekswebnet deleted the fix/h5p-author-review-162 branch November 12, 2026 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

h5p-author: findings from the 2026-11-09 skill eval and code review

1 participant