Skip to content

test(player): compare large byte arrays directly in the range handle … - #135

Merged
alekswebnet merged 1 commit into
mainfrom
perf/range-read-cache
Nov 4, 2026
Merged

alekswebnet merged 1 commit into
mainfrom
perf/range-read-cache

Conversation

@alekswebnet

Copy link
Copy Markdown
Contributor

…tests

CI timed out "fetches a read longer than the bound as asked" at 5 s. The read was not slow: toEqual walks a typed array element by element through its generic equality, 1.9 s locally for the two 1 MB comparisons and more on CI's runners. A direct comparison takes the case to 5 ms, and the stream case from 0.65 s to 12 ms.

Summary

Changes

Verification

  • Tests added or updated where behavior changed
  • Documentation updated where public behavior or deployment changed
  • Relevant type checks, tests, and builds pass
  • No security-sensitive details or credentials are included

Screenshots or reproduction

…tests

CI timed out "fetches a read longer than the bound as asked" at 5 s. The
read was not slow: toEqual walks a typed array element by element through
its generic equality, 1.9 s locally for the two 1 MB comparisons and more
on CI's runners. A direct comparison takes the case to 5 ms, and the
stream case from 0.65 s to 12 ms.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@alekswebnet
alekswebnet merged commit bca19e3 into main Nov 4, 2026
6 checks passed
@alekswebnet
alekswebnet deleted the perf/range-read-cache branch November 6, 2026 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant