Repository navigation
test(player): compare large byte arrays directly in the range handle … - #135
Merged
Merged
Conversation
…tests CI timed out "fetches a read longer than the bound as asked" at 5 s. The read was not slow: toEqual walks a typed array element by element through its generic equality, 1.9 s locally for the two 1 MB comparisons and more on CI's runners. A direct comparison takes the case to 5 ms, and the stream case from 0.65 s to 12 ms. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…tests
CI timed out "fetches a read longer than the bound as asked" at 5 s. The read was not slow: toEqual walks a typed array element by element through its generic equality, 1.9 s locally for the two 1 MB comparisons and more on CI's runners. A direct comparison takes the case to 5 ms, and the stream case from 0.65 s to 12 ms.
Summary
Changes
Verification
Screenshots or reproduction