Repository navigation
chore(dependabot): leave @types/vscode at the extension's VS Code floor - #129
Merged
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
There are no active review issues for the Dependabot exclusion of @types/vscode and the documentation of manual version alignment.
No open issues 🎉
What changed in this PR
Prevents recurring extension packaging failures by keeping Dependabot from updating @types/vscode beyond the minimum supported VS Code version, addressing #128.
Changes:
- Excludes
@types/vscodefrom Dependabot updates while preserving the existing development-dependency group. - Documents that VS Code types and
engines.vscodemust be updated together manually. No application code changes.
| File | Description |
|---|---|
| AGENTS.md | Documents the VS Code types compatibility requirement and manual update policy. |
| .github/dependabot.yml | Adds an ignore entry for @types/vscode with an explanatory comment. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #128.
Dependabot's weekly group raised
@types/vscodefrom 1.90.0 to 1.144.0 in #125, and the extension's job failed on vsce's check:Copilot's coding agent set it back in that PR, but the next weekly run would propose it again. This adds an
ignoreentry for@types/vscodeto.github/dependabot.yml, with a comment on why, so the types move withengines.vscode, by hand, when the floor does. AGENTS.md's section on the extension says the same.No code changes; the other development dependencies are grouped as before.
🤖 Generated with Claude Code