Skip to content

chore(dependabot): leave @types/vscode at the extension's VS Code floor - #129

Merged
alekswebnet merged 1 commit into
mainfrom
chore/dependabot-vscode-types
Nov 4, 2026
Merged

alekswebnet merged 1 commit into
mainfrom
chore/dependabot-vscode-types

Conversation

@alekswebnet

Copy link
Copy Markdown
Contributor

Closes #128.

Dependabot's weekly group raised @types/vscode from 1.90.0 to 1.144.0 in #125, and the extension's job failed on vsce's check:

@types/vscode 1.144.0 greater than engines.vscode ^1.90.0. Either upgrade engines.vscode or use an older @types/vscode version

Copilot's coding agent set it back in that PR, but the next weekly run would propose it again. This adds an ignore entry for @types/vscode to .github/dependabot.yml, with a comment on why, so the types move with engines.vscode, by hand, when the floor does. AGENTS.md's section on the extension says the same.

No code changes; the other development dependencies are grouped as before.

🤖 Generated with Claude Code

Dependabot's weekly group raised @types/vscode to 1.144.0 in #125, past the
extension's engines.vscode (^1.90.0), and vsce refused to package it. The
types now move with engines.vscode, by hand.

Closes #128

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

There are no active review issues for the Dependabot exclusion of @types/vscode and the documentation of manual version alignment.

No open issues 🎉

What changed in this PR

Prevents recurring extension packaging failures by keeping Dependabot from updating @types/vscode beyond the minimum supported VS Code version, addressing #128.

Changes:

  • Excludes @types/vscode from Dependabot updates while preserving the existing development-dependency group.
  • Documents that VS Code types and engines.vscode must be updated together manually. No application code changes.
File Description
AGENTS.md Documents the VS Code types compatibility requirement and manual update policy.
.github/​dependabot.yml Adds an ignore entry for @types/vscode with an explanatory comment.

Review effort: Balanced

@alekswebnet
alekswebnet merged commit 68b7103 into main Nov 4, 2026
9 checks passed
@alekswebnet
alekswebnet deleted the chore/dependabot-vscode-types branch November 6, 2026 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dependabot raises @types/vscode past the extension's VS Code floor, and packaging fails

2 participants